Skip to content

Commit 9ba5a9a

Browse files
committed
[MWRAPPER-134] Add wrapperVersion to maven-wrapper.properties
That contains the current version of the deployed Maven Wrapper --- https://issues.apache.org/jira/browse/MWRAPPER-134
1 parent c4c09a3 commit 9ba5a9a

File tree

8 files changed

+36
-2
lines changed

8 files changed

+36
-2
lines changed

maven-wrapper-plugin/pom.xml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -176,6 +176,9 @@ under the License.
176176
<artifact>org.apache.maven.wrapper:maven-wrapper-distribution:${project.version}:zip:script</artifact>
177177
<artifact>org.apache.maven.wrapper:maven-wrapper-distribution:${project.version}:zip:source</artifact>
178178
</extraArtifacts>
179+
<scriptVariables>
180+
<wrapperCurrentVersion>${project.version}</wrapperCurrentVersion>
181+
</scriptVariables>
179182
</configuration>
180183
<executions>
181184
<execution>

maven-wrapper-plugin/src/it/projects/default/verify.groovy

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,3 +29,9 @@ log = new File(basedir, 'build.log').text
2929
assert log.contains('[INFO] Unpacked only-script type wrapper distribution org.apache.maven.wrapper:maven-wrapper-distribution:zip:only-script:')
3030
// check "mvnw -v" output
3131
assert log.contains('Apache Maven ')
32+
33+
Properties props = new Properties()
34+
new File(basedir,'.mvn/wrapper/maven-wrapper.properties').withInputStream {
35+
props.load(it)
36+
}
37+
assert props.wrapperVersion.equals(wrapperCurrentVersion)

maven-wrapper-plugin/src/it/projects/mavenversion/verify.groovy

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,11 +26,11 @@ assert !(new File(basedir,'mvnwDebug.cmd').exists())
2626
def propertiesFile = new File(basedir,'.mvn/wrapper/maven-wrapper.properties')
2727
assert propertiesFile.exists()
2828

29-
def props = new Properties()
29+
Properties props = new Properties()
3030
propertiesFile.withInputStream {
3131
props.load(it)
3232
}
33-
33+
assert props.wrapperVersion.equals(wrapperCurrentVersion)
3434
assert props.distributionUrl.endsWith('/org/apache/maven/apache-maven/3.6.3/apache-maven-3.6.3-bin.zip')
3535

3636
log = new File(basedir, 'build.log').text

maven-wrapper-plugin/src/it/projects/type_bin/verify.groovy

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,3 +30,9 @@ log = new File(basedir, 'build.log').text
3030
assert log.contains('[INFO] Unpacked bin type wrapper distribution org.apache.maven.wrapper:maven-wrapper-distribution:zip:bin:')
3131
// check "mvnw -v" output
3232
assert log.contains('Apache Maven ')
33+
34+
Properties props = new Properties()
35+
new File(basedir,'.mvn/wrapper/maven-wrapper.properties').withInputStream {
36+
props.load(it)
37+
}
38+
assert props.wrapperVersion.equals(wrapperCurrentVersion)

maven-wrapper-plugin/src/it/projects/type_only-script/verify.groovy

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,3 +34,9 @@ assert log.contains('[INFO] Unpacked only-script type wrapper distribution org.a
3434
// check "mvnw -v" output
3535
assert log.contains("Couldn't find ")
3636
assert log.contains(", downloading and installing it ...")
37+
38+
Properties props = new Properties()
39+
new File(basedir,'.mvn/wrapper/maven-wrapper.properties').withInputStream {
40+
props.load(it)
41+
}
42+
assert props.wrapperVersion.equals(wrapperCurrentVersion)

maven-wrapper-plugin/src/it/projects/type_script/verify.groovy

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,3 +35,9 @@ assert log.contains('[INFO] Unpacked script type wrapper distribution org.apache
3535
assert log.contains("Couldn't find ")
3636
assert log.contains(", downloading it ...")
3737
assert new File(basedir,'.mvn/wrapper/maven-wrapper.jar').exists()
38+
39+
Properties props = new Properties()
40+
new File(basedir,'.mvn/wrapper/maven-wrapper.properties').withInputStream {
41+
props.load(it)
42+
}
43+
assert props.wrapperVersion.equals(wrapperCurrentVersion)

maven-wrapper-plugin/src/it/projects/type_source/verify.groovy

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,3 +33,9 @@ assert log.contains('[INFO] Unpacked source type wrapper distribution org.apache
3333
assert log.contains("Couldn't find ")
3434
assert log.contains(", downloading it ...")
3535
assert new File(basedir,'.mvn/wrapper/maven-wrapper.jar').exists()
36+
37+
Properties props = new Properties()
38+
new File(basedir,'.mvn/wrapper/maven-wrapper.properties').withInputStream {
39+
props.load(it)
40+
}
41+
assert props.wrapperVersion.equals(wrapperCurrentVersion)

maven-wrapper-plugin/src/main/java/org/apache/maven/plugins/wrapper/WrapperMojo.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -287,6 +287,7 @@ private void replaceProperties(String wrapperVersion, Path targetFolder) throws
287287

288288
try (BufferedWriter out = Files.newBufferedWriter(wrapperPropertiesFile, StandardCharsets.UTF_8)) {
289289
out.append(String.format(Locale.ROOT, license));
290+
out.append("wrapperVersion=" + wrapperVersion + System.lineSeparator());
290291
out.append("distributionUrl=" + distributionUrl + System.lineSeparator());
291292
if (distributionSha256Sum != null) {
292293
out.append("distributionSha256Sum=" + distributionSha256Sum + System.lineSeparator());

0 commit comments

Comments
 (0)