crypto/mbedtls: Use config defining flag globally

Now -DMBEDTLS_USER_CONFIG_FILE=<mbedtls/config_mynewt.h> flag is
used globally for each build that depends on mbedtls package.
This way we won't have to add this flag in each package
that uses mbedtls.

Author: m-gorecki

apps/crypto_test/pkg.yml

@@ -28,5 +28,3 @@ pkg.deps:
     - "@apache-mynewt-core/sys/log"
     - "@apache-mynewt-core/crypto/mbedtls"
     - "@apache-mynewt-core/crypto/tinycrypt"
-
-pkg.cflags: '-DMBEDTLS_USER_CONFIG_FILE="mbedtls/config_mynewt.h"'

apps/hash_test/pkg.yml

@@ -28,5 +28,3 @@ pkg.deps:
     - "@apache-mynewt-core/sys/log"
     - "@apache-mynewt-core/crypto/mbedtls"
     - "@apache-mynewt-core/crypto/tinycrypt"
-
-pkg.cflags: '-DMBEDTLS_USER_CONFIG_FILE="mbedtls/config_mynewt.h"'

crypto/mbedtls/include/mbedtls/config_mynewt.h

@@ -42,8 +42,9 @@ extern "C" {
 #define MBEDTLS_NO_PLATFORM_ENTROPY
 #undef MBEDTLS_NET_C
 
-#ifndef TEST
 #undef MBEDTLS_SELF_TEST
+#if MYNEWT_VAL(TEST)
+#define MBEDTLS_SELF_TEST
 #endif
 
 #define MBEDTLS_SHA256_SMALLER          /* Comes with performance hit */

crypto/mbedtls/pkg.yml

@@ -26,8 +26,10 @@ pkg.keywords:
     - tls
 pkg.type: sdk
 
-pkg.cflags:
+app.cflags:
     - '-DMBEDTLS_USER_CONFIG_FILE=<mbedtls/config_mynewt.h>'
+
+pkg.cflags:
     - -Wno-maybe-uninitialized
     - -Wno-unknown-warning-option
 pkg.cflags.TEST: -DTEST

crypto/mbedtls/syscfg.yml

@@ -119,8 +119,10 @@ syscfg.defs:
     value: 0
   MBEDTLS_CIPHER_MODE_CFB:
     value: 0
+  # XXX: This should be 0 on default, but mcuboot's test needs this enabled. Until a new mcuboot version with this
+  # config enabled is released we have to enable this by default.
   MBEDTLS_CIPHER_MODE_CTR:
-    value: 0
+    value: 1
   MBEDTLS_CIPHER_MODE_OFB:
     value: 0
   MBEDTLS_CIPHER_MODE_XTS: