PHOENIX-6879 Prometheus endpoint implementation #119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Notes: - added a new servlet (/prometheus) for exposing Prometheus format metrics - metrics description can be enabled by "/prometheus?description=true" query string - metrics can be filtered by "/prometheus?qry=xyz" query string
MitchellJThomas
left a comment
MitchellJThomas
left a comment
There was a problem hiding this comment.
Some suggestions. You might also want to add a unit test or two.
| HandlerList list = (HandlerList) handlers[0]; | ||
|
|
||
| ServletContextHandler ctx = new ServletContextHandler(); | ||
| ctx.setContextPath("/prometheus"); |
There was a problem hiding this comment.
Prometheus typically expects and endpoint path to be "/metrics".
| for (AbstractMetric metrics : metricsRecord.metrics()) { | ||
| if (metrics.type() == MetricType.COUNTER || metrics.type() == MetricType.GAUGE) { | ||
|
|
||
| String key = toPrometheusName(metricsRecord.name(), metrics.name()); |
There was a problem hiding this comment.
Note that this method and its regexp could be called quite often: per metricRecord, per metric, per metric scrape interval (default scrape interval is 1 minute) could add to a bit of CPU time... if I am right, I suggest memoizing this function
Notes: - Added some unit tests for PrometheusHadoopServlet and PrometheusEndpointServerCustomizer - Changed PrometheusHadoopServlet.toPrometheusName() function's visibility to package-private
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this change:
"/prometheus?description=true"query string"/prometheus?qry=xyz"query string