code review

Author: vrozov

sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DaysWritableV2.scala

@@ -110,7 +110,7 @@ class HadoopTableReader(
    */
   def makeRDDForTable(
       hiveTable: HiveTable,
-      abstractSerDeClass: Class[_ <: AbstractSerDe],
+      deserializerClass: Class[_ <: AbstractSerDe],
       filterOpt: Option[PathFilter]): RDD[InternalRow] = {
 
     assert(!hiveTable.isPartitioned,
@@ -133,11 +133,11 @@ class HadoopTableReader(
 
     val deserializedHadoopRDD = hadoopRDD.mapPartitions { iter =>
       val hconf = broadcastedHadoopConf.value.value
-      val abstractSerDe = abstractSerDeClass.getConstructor().newInstance()
+      val deserializer = deserializerClass.getConstructor().newInstance()
       DeserializerLock.synchronized {
-        abstractSerDe.initialize(hconf, localTableDesc.getProperties, null)
+        deserializer.initialize(hconf, localTableDesc.getProperties, null)
       }
-      HadoopTableReader.fillObject(iter, abstractSerDe, attrsWithIndex, mutableRow, abstractSerDe)
+      HadoopTableReader.fillObject(iter, deserializer, attrsWithIndex, mutableRow, deserializer)
     }
 
     deserializedHadoopRDD
@@ -181,7 +181,7 @@ class HadoopTableReader(
       }
 
       val broadcastedHiveConf = _broadcastedHadoopConf
-      val localAbstractSerDeClass = partDeserializerClass
+      val localDeserializerClass = partDeserializerClass
       val mutableRow = new SpecificInternalRow(attributes.map(_.dataType))
 
       // Splits all attributes into two groups, partition key attributes and those that are not.
@@ -210,7 +210,7 @@ class HadoopTableReader(
 
       createHadoopRDD(partDesc, inputPathStr).mapPartitions { iter =>
         val hconf = broadcastedHiveConf.value.value
-        val deserializer = localAbstractSerDeClass.getConstructor().newInstance()
+        val deserializer = localDeserializerClass.getConstructor().newInstance()
           .asInstanceOf[AbstractSerDe]
         // SPARK-13709: For SerDes like AvroSerDe, some essential information (e.g. Avro schema
         // information) may be defined in table properties. Here we should merge table properties

sql/hive/src/main/scala/org/apache/spark/sql/hive/TableReader.scala

@@ -520,7 +520,6 @@ private[client] class Shim_v2_0 extends Shim with Logging {
   override def alterTable(hive: Hive, tableName: String, table: Table): Unit = {
     recordHiveCall()
     alterTableMethod.invoke(hive, tableName, table)
-    // hive.alterTable(tableName, table, )
   }
 
   override def alterPartitions(hive: Hive, tableName: String, newParts: JList[Partition]): Unit = {