Skip to content

Commit 88545fa

Browse files
committed
Add support Python 3.14 for SqlStorageClient with PostgreSQL
1 parent 9d4ae64 commit 88545fa

File tree

3 files changed

+56
-49
lines changed

3 files changed

+56
-49
lines changed

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ otel = [
7474
]
7575
sql_postgres = [
7676
"sqlalchemy[asyncio]>=2.0.0,<3.0.0",
77-
"asyncpg>=0.24.0; python_version < '3.14'" # TODO: https://github.com/apify/crawlee-python/issues/1555
77+
"asyncpg>=0.24.0"
7878
]
7979
sql_sqlite = [
8080
"sqlalchemy[asyncio]>=2.0.0,<3.0.0",

src/crawlee/storage_clients/_sql/_storage_client.py

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
from __future__ import annotations
22

3-
import sys
43
import warnings
54
from datetime import timedelta
65
from pathlib import Path
@@ -269,14 +268,6 @@ def _get_or_create_engine(self, configuration: Configuration) -> AsyncEngine:
269268
'Unsupported database. Supported: sqlite, postgresql. Consider using a different database.'
270269
)
271270

272-
# TODO: https://github.com/apify/crawlee-python/issues/1555
273-
if 'postgresql' in connection_string and sys.version_info >= (3, 14):
274-
raise ValueError(
275-
'SqlStorageClient cannot use PostgreSQL with Python 3.14 '
276-
'due to asyncpg compatibility limitations. '
277-
'Please use Python 3.13 or earlier, or switch to SQLite.'
278-
)
279-
280271
self._engine = create_async_engine(
281272
connection_string,
282273
future=True,

0 commit comments

Comments
 (0)