error handling

Author: jryannel

src/olink/clientnode.py

@@ -9,6 +9,7 @@ class InvokeReplyArg:
     def __init__(self, name: str, value: Any):
         self.name = name
         self.value = value
+
     name: str
     value: Any
 
@@ -71,7 +72,8 @@ def remove_node_from_sink(self, name: str, node: "ClientNode"):
                 self.entries[resource].node = None
             else:
                 self.emit_log(
-                    LogLevel.DEBUG, f"unlink node failed, not the same node: {resource}")
+                    LogLevel.DEBUG, f"unlink node failed, not the same node: {resource}"
+                )
 
     def register_sink(self, sink: IObjectSink) -> "ClientNode":
         # register sink using object name
@@ -131,18 +133,18 @@ def next_request_id(self) -> int:
         self.requestId += 1
         return self.requestId
 
-    def invoke_remote(self, name: str, args: list[Any], func: Optional[InvokeReplyFunc]) -> None:
-        self.emit_log(LogLevel.DEBUG,
-                      f"ClientNode.invoke_remote: {name} {args}")
+    def invoke_remote(
+        self, name: str, args: list[Any], func: Optional[InvokeReplyFunc]
+    ) -> None:
+        self.emit_log(LogLevel.DEBUG, f"ClientNode.invoke_remote: {name} {args}")
         request_id = self.next_request_id()
         if func:
             self.invokes_pending[request_id] = func
         self.emit_write(Protocol.invoke_message(request_id, name, args))
 
     def set_remote_property(self, name: str, value: Any) -> None:
         # send remote propertymessage
-        self.emit_log(LogLevel.DEBUG,
-                      f"ClientNode.set_remote_property: {name} {value}")
+        self.emit_log(LogLevel.DEBUG, f"ClientNode.set_remote_property: {name} {value}")
         self.emit_write(Protocol.set_property_message(name, value))
 
     def link_node(self, name: str):
@@ -189,16 +191,16 @@ def handle_init(self, name: str, props: object):
 
     def handle_property_change(self, name: str, value: Any) -> None:
         # handle property change message from source
-        self.emit_log(LogLevel.DEBUG,
-                      f"ClientNode.handle_property_change: {name}")
+        self.emit_log(LogLevel.DEBUG, f"ClientNode.handle_property_change: {name}")
         sink = self.get_sink(name)
         if sink:
             sink.olink_on_property_changed(name, value)
 
     def handle_invoke_reply(self, id: int, name: str, value: Any) -> None:
         # handle invoke reply message from source
-        self.emit_log(LogLevel.DEBUG,
-                      f"ClientNode.handle_invoke_reply: {id} {name} {value}")
+        self.emit_log(
+            LogLevel.DEBUG, f"ClientNode.handle_invoke_reply: {id} {name} {value}"
+        )
         if id in self.invokes_pending:
             func = self.invokes_pending[id]
             if func:
@@ -210,13 +212,13 @@ def handle_invoke_reply(self, id: int, name: str, value: Any) -> None:
 
     def handle_signal(self, name: str, args: list[Any]) -> None:
         # handle signal message from source
-        self.emit_log(LogLevel.DEBUG,
-                      f"ClientNode.handle_signal: {name} {args}")
+        self.emit_log(LogLevel.DEBUG, f"ClientNode.handle_signal: {name} {args}")
         sink = self.get_sink(name)
         if sink:
             sink.olink_on_signal(name, args)
 
     def handle_error(self, msgType: MsgType, id: int, error: str):
         # handle error message from source
-        self.emit_log(LogLevel.DEBUG,
-                      f"ClientNode.handle_error: {msgType} {id} {error}")
+        self.emit_log(
+            LogLevel.DEBUG, f"ClientNode.handle_error: {msgType} {id} {error}"
+        )

src/olink/core/node.py

@@ -1,6 +1,13 @@
+import logging
 from typing import Any
 from olink.core.protocol import IProtocolListener, Protocol
-from olink.core.types import Base, LogLevel, MessageConverter, MessageFormat, WriteMessageFunc
+from olink.core.types import (
+    Base,
+    LogLevel,
+    MessageConverter,
+    MessageFormat,
+    WriteMessageFunc,
+)
 
 
 class BaseNode(Base, IProtocolListener):
@@ -28,5 +35,9 @@ def emit_write(self, msg: list[Any]) -> None:
 
     def handle_message(self, data: str) -> None:
         # handle a message and pass is on to the protocol
-        msg = self.converter.from_string(data)
-        self.protocol.handle_message(msg)
+        try:
+            msg = self.converter.from_string(data)
+            self.protocol.handle_message(msg)
+        except Exception as e:
+            logging.error("handle_message error: %s", e)
+            raise e