From 752dca9c54aa071c6bafc1c705cd19150931b185 Mon Sep 17 00:00:00 2001 From: Peter Boling Date: Fri, 24 Apr 2020 05:05:07 -0600 Subject: [PATCH 1/3] Allow latest rubocop --- lib/quality/config.rb | 1 + quality.gemspec | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/quality/config.rb b/lib/quality/config.rb index 0ee2480..7dc1527 100644 --- a/lib/quality/config.rb +++ b/lib/quality/config.rb @@ -4,6 +4,7 @@ # https://github.com/xsc/lein-ancient/issues/29 # https://github.com/xsc/lein-ancient/releases +require 'forwardable' require_relative 'linguist_source_file_globber' module Quality diff --git a/quality.gemspec b/quality.gemspec index 62c8b43..609fd23 100644 --- a/quality.gemspec +++ b/quality.gemspec @@ -42,7 +42,7 @@ Gem::Specification.new do |s| # # https://github.com/bbatsov/rubocop#installation s.add_runtime_dependency('mdl') - s.add_runtime_dependency('rubocop', '~> 0.78.0') + s.add_runtime_dependency('rubocop', '>= 0.78') # 0.2.0 had a fatal bug s.add_runtime_dependency('bigfiles', ['>= 0.1', '!= 0.2.0']) s.add_runtime_dependency('brakeman') From d0b68abfcc4933047f348c4da761c8765560de51 Mon Sep 17 00:00:00 2001 From: Peter Boling Date: Fri, 24 Apr 2020 05:05:17 -0600 Subject: [PATCH 2/3] Commit last run --- coverage/.last_run.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/coverage/.last_run.json b/coverage/.last_run.json index 34372de..57e60f5 100644 --- a/coverage/.last_run.json +++ b/coverage/.last_run.json @@ -1,5 +1,5 @@ { "result": { - "covered_percent": 97.82 + "covered_percent": 45.63 } } From 0ef6ba7728a4bb6c9fd15fa9f826fc245837cc4e Mon Sep 17 00:00:00 2001 From: Peter Boling Date: Fri, 24 Apr 2020 05:13:35 -0600 Subject: [PATCH 3/3] Update README --- README.md | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/README.md b/README.md index d0224c3..d476a14 100644 --- a/README.md +++ b/README.md @@ -147,11 +147,15 @@ Quality uses [semantic versioning](http://semver.org/)--any incompatible changes (including new tools being added) will come out as major number updates. -This includes RuboCop upgrades - the quality gem locks in a specific -minor version of RuboCop to avoid your metrics being bumped and -breaking your build. - -Expect your build to break on major upgrades if you use RuboCop. +New versions of rubocop, however, will often introduce new rules, which +won't be universally adhered to in your code, which in turn may ratchet your +metrics in the wrong direction! As a result of this we recommend +you lock your Gemfile to a specific minor version of rubocop. + +Expect your build to break on major upgrades of this gem, +and minor version upgrades of rubocop. Because this gem requires +rubocop, rubocop will get updated when you update this gem, unless +you have an explicit constraint on rubocop preventing it (AND YOU SHOULD!). ## Supported Ruby Versions