apostrophe-users:add does not work via cli tool

[benirose]

I know the cli is not the recommended way to running apostrophe tasks, but since it's a documented feature I thought I would log this issue. I tried to run apostrophe apostrophe-users:add admin admin during my project set up, but got an error. It worked when running node app.js ...

$ apos apostrophe-users:add admin admin
 
 Apostrophe  apostrophe-users:add  Running the task [1/1]
WARNING: No session secret provided, please set the `secret` property of the `session` property of the apostrophe-express module in app.js
Incorrect number of arguments.
 
 Apostrophe  apostrophe-users:add  Failed

$ node app.js apostrophe-users:add admin admin
WARNING: No session secret provided, please set the `secret` property of the `session` property of the apostrophe-express module in app.js
prompt: password:  

[benirose]

Took another look into this today, and it seems like the cli is not set up to pass arguments to any of the apostrophe commands. I may adjust this and submit a PR.

[benirose]

It looks like commander doesn't support arguments and options on wildcard commands. We could parse process.argv to get them, not sure if this is something you're interested in supporting or not. Let me know and I can make the change and submit a PR.

[boutell]

Thanks for flagging this Ben. A PR would be welcome.

…

On Thu, Aug 3, 2017 at 11:02 AM, Ben Rosenbach ***@***.***> wrote: It looks like commander doesn't support arguments and options on wildcard commands. We could parse process.argv to get them, not sure if this is something you're interested in supporting or not. Let me know and I can make the change and submit a PR. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#13 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAB9fUCbWtgJ2X71HskM15Jo6BD8zrWfks5sUeCrgaJpZM4N1Y6H> .

-- *THOMAS BOUTELL, *SUPPORT LEAD P'UNK AVENUE | (215) 755-1330 | punkave.com

[abea]

@boutell Given that running core apostrophe tasks is a "nice to have" I suggest we deprecate that feature of the CLI. It could be brought back later, but I'm running across a bug while working on this issue where if I'm resetting a password the text I type in is no longer replaced by ******** if I use apos apostrophe-users:change-password. It does when using node app directly.

The amount of work to get this "nice to have" working property seems outsized to its value.

[boutell]

Agreed, we should deprecate it.

…

On Thu, Jun 4, 2020 at 5:29 PM Alex Bea ***@***.***> wrote: @boutell <https://github.com/boutell> Given that running core apostrophe tasks is a "nice to have" I suggest we deprecate that feature of the CLI. It could be brought back later, but I'm running across a bug while working on this issue where if I'm resetting a password the text I type in is no longer replaced by ******** if I use apos apostrophe-users:change-password. It does when using node app directly. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#13 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAH27KEMD2ENT57NIA76JTRVAGZZANCNFSM4DOVR2DQ> .

-- THOMAS BOUTELL | CHIEF TECHNOLOGY OFFICER APOSTROPHECMS | apostrophecms.com | he/him/his

[abea]

Given that it's a tool and not an application, do you see that as a BC break needing a major version? It might be worth bumping to a major version for the analytics addition anyway (not necessary, but makes some sense).

[boutell]

If it doesn't support it even as well as before that's a bc break needing a major version.

…

On Fri, Jun 5, 2020 at 9:29 AM Alex Bea ***@***.***> wrote: Given that it's a tool and not an application, do you see that as a BC break needing a major version? It might be worth bumping to a major version for the analytics addition anyway (not necessary, but makes some sense). — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#13 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAH27LJQMPG3676U4KP3NLRVDXLZANCNFSM4DOVR2DQ> .

-- THOMAS BOUTELL | CHIEF TECHNOLOGY OFFICER APOSTROPHECMS | apostrophecms.com | he/him/his