From fb3f196c440f6fee358ad3cdb873be5a455a699c Mon Sep 17 00:00:00 2001 From: David Date: Mon, 14 Nov 2022 10:43:16 -0800 Subject: [PATCH 1/2] chore: potential forward ref components --- src/components/Activity/Activity.tsx | 1 + src/components/Activity/ActivityLog.tsx | 1 + src/components/Address/CountryInput.tsx | 1 + src/components/Address/StateInput.tsx | 1 + src/components/Alert/Alert.tsx | 1 + src/components/BlockPanel/BlockPanel.tsx | 1 + src/components/Button/Close.tsx | 1 + src/components/Button/ConfirmationButton.tsx | 1 + src/components/Calendar/Calendar.tsx | 1 + src/components/Calendar/components/Day.tsx | 1 + src/components/Callout/Callout.tsx | 1 + src/components/Carousel/ImageCarousel.js | 1 + src/components/Carousel/UncontrolledCarousel.js | 1 + src/components/Checkbox/CheckboxBooleanInput.tsx | 1 + src/components/Checkbox/CheckboxInput.tsx | 1 + src/components/Checkbox/CheckboxListInput.tsx | 2 ++ src/components/ClickableContainer/ClickableContainer.tsx | 1 + src/components/Combobox/Combobox.tsx | 2 ++ src/components/Datapair/Datapair.tsx | 1 + src/components/Form/BoundForm.js | 1 + src/components/Form/FormChoice.js | 1 + src/components/Form/FormGroup.tsx | 1 + src/components/Form/FormRow.tsx | 1 + src/components/HasManyFields/HasManyFieldsAdd.js | 1 + src/components/HasManyFields/HasManyFieldsRow.tsx | 1 + src/components/HelpBubble/HelpBubble.tsx | 1 + src/components/Icon/FontAwesomeAPM.tsx | 1 + src/components/Icon/Icon.tsx | 1 + src/components/InfoBox/InfoBox.tsx | 1 + src/components/Input/CreditCardNumber.tsx | 1 + src/components/Input/CurrencyInput.tsx | 1 + src/components/Input/DateInput.js | 1 + src/components/Input/FileInput.tsx | 1 + src/components/Input/MaskedInput.tsx | 1 + src/components/Input/MonthInput.js | 1 + src/components/Input/PatternInput.js | 1 + src/components/Input/StaticInput.tsx | 1 + src/components/Input/TimeInput.js | 1 + src/components/List/List.tsx | 1 + src/components/List/ListGroup.tsx | 1 + src/components/List/ListItem.tsx | 1 + src/components/List/SortableList.tsx | 1 + src/components/List/components/FilterHeader.tsx | 1 + src/components/Modal/Modal.js | 1 + src/components/MultiSelectCombobox/MultiSelectCombobox.tsx | 1 + src/components/Placeholder/Placeholder.tsx | 1 + src/components/Popover/Popover.tsx | 1 + src/components/Popover/PopoverHeader.tsx | 1 + src/components/Radio/RadioInput.tsx | 1 + src/components/ScrollContainer/ScrollContainer.tsx | 1 + src/components/Select/Select.js | 1 + src/components/Select/SelectMultiValue.js | 1 + src/components/Spinner/ApmSpinner.tsx | 1 + src/components/Spinner/Spinner.tsx | 1 + src/components/Status/Status.tsx | 1 + src/components/SummaryBox/SummaryBox.tsx | 1 + src/components/SummaryBox/SummaryBoxItem.tsx | 1 + src/components/Table/SortableTable.js | 1 + src/components/Table/Table.tsx | 1 + src/components/Table/UncontrolledTable.js | 1 + src/components/Tooltip/Tooltip.tsx | 1 + src/components/Tooltip/TooltipButton.tsx | 1 + src/components/Tree/Tree.tsx | 1 + src/components/Tree/TreeItem.tsx | 1 + src/components/Waiting/Waiting.tsx | 1 + 65 files changed, 67 insertions(+) diff --git a/src/components/Activity/Activity.tsx b/src/components/Activity/Activity.tsx index dce2bc5e9..8ff57711c 100644 --- a/src/components/Activity/Activity.tsx +++ b/src/components/Activity/Activity.tsx @@ -17,6 +17,7 @@ interface ActivityProps extends Omit { * Extension to Bootstrap [ListGroupItem](https://getbootstrap.com/docs/4.3/components/list-group-item/) * representing a timeline event. */ +// Forward ref const Activity: FC = ({ action, by, diff --git a/src/components/Activity/ActivityLog.tsx b/src/components/Activity/ActivityLog.tsx index ea8a0d0f1..1b1e597d2 100644 --- a/src/components/Activity/ActivityLog.tsx +++ b/src/components/Activity/ActivityLog.tsx @@ -5,6 +5,7 @@ import { ListGroup, ListGroupProps } from 'reactstrap'; * Extension to Bootstrap [ListGroup](https://getbootstrap.com/docs/4.3/components/list-group/) * for listing a timeline of Activities */ +// Passes in ref const ActivityLog: FC = ({ children, ...props }) => ( {children} ); diff --git a/src/components/Address/CountryInput.tsx b/src/components/Address/CountryInput.tsx index 51993851d..61295fe19 100644 --- a/src/components/Address/CountryInput.tsx +++ b/src/components/Address/CountryInput.tsx @@ -15,6 +15,7 @@ const defaultProps = { onChange: () => {}, }; +// Forwards ref const CountryInput: FC = ({ onChange = defaultProps.onChange, ...otherProps diff --git a/src/components/Address/StateInput.tsx b/src/components/Address/StateInput.tsx index efedcbebc..908ce14b2 100644 --- a/src/components/Address/StateInput.tsx +++ b/src/components/Address/StateInput.tsx @@ -31,6 +31,7 @@ const defaultProps = { onChange: () => {}, }; +// Forwards ref const StateInput: FC = ({ className, countries = defaultProps.countries, diff --git a/src/components/Alert/Alert.tsx b/src/components/Alert/Alert.tsx index cd922fc0d..6c5282397 100644 --- a/src/components/Alert/Alert.tsx +++ b/src/components/Alert/Alert.tsx @@ -21,6 +21,7 @@ type Props = { * Extension to Bootstrap [Alert](https://getbootstrap.com/docs/4.3/components/alert/) * adding icon support and onToggle callback when dismissed. */ +// passes in ref potentially const Alert: FC = ({ color = 'warning', children, diff --git a/src/components/BlockPanel/BlockPanel.tsx b/src/components/BlockPanel/BlockPanel.tsx index 2da5e016e..ae14a6c9a 100644 --- a/src/components/BlockPanel/BlockPanel.tsx +++ b/src/components/BlockPanel/BlockPanel.tsx @@ -59,6 +59,7 @@ const defaultProps = { /** * BlockPanel is an extension to Bootstrap Card, which allows for expand/collapse and standardized header. */ +// Ref stuff const BlockPanel: FC = ({ children, className = defaultProps.className, diff --git a/src/components/Button/Close.tsx b/src/components/Button/Close.tsx index e77942179..b6ecdad10 100644 --- a/src/components/Button/Close.tsx +++ b/src/components/Button/Close.tsx @@ -1,5 +1,6 @@ import React, { FC } from 'react'; +// Pass in ref here const Close: FC> = ({ className = '', ...props }) => (