Skip to content

Commit 7f0b907

Browse files
committed
Review comments - better names for role patches
1 parent eba67fb commit 7f0b907

18 files changed

+14
-14
lines changed

internal/deploy/kustomize/daily/examples/watch-all-namespaces/kustomization.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,5 +7,5 @@ namespace: rco-ns
77
resources:
88
- ../../overlays/watch-all-namespaces
99
patches:
10-
- path: role1.yaml
11-
- path: role2.yaml
10+
- path: rco-leader-election-cluster-rolebinding.yaml
11+
- path: rco-manager-cluster-rolebinding.yaml

internal/deploy/kustomize/daily/examples/watch-all-namespaces/role1.yaml renamed to internal/deploy/kustomize/daily/examples/watch-all-namespaces/rco-leader-election-cluster-rolebinding.yaml

File renamed without changes.

internal/deploy/kustomize/daily/examples/watch-all-namespaces/role2.yaml renamed to internal/deploy/kustomize/daily/examples/watch-all-namespaces/rco-manager-cluster-rolebinding.yaml

File renamed without changes.

internal/deploy/kustomize/daily/examples/watch-another-namespace/rco-ns2/kustomization.yaml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@ resources:
77
- ../../../overlays/watch-another-namespace/rco-ns
88
patches:
99
- path: rco-deployment.yaml
10-
- path: role1.yaml
11-
- path: role2.yaml
12-
- path: role3.yaml
13-
- path: role4.yaml
10+
- path: rco-leader-election-role.yaml
11+
- path: rco-manager-role.yaml
12+
- path: rco-leader-election-rolebinding.yaml
13+
- path: rco-manager-rolebinding.yaml
1414
- path: rco-sa.yaml

internal/deploy/kustomize/daily/examples/watch-another-namespace/rco-ns2/role1.yaml renamed to internal/deploy/kustomize/daily/examples/watch-another-namespace/rco-ns2/rco-leader-election-role.yaml

File renamed without changes.

internal/deploy/kustomize/daily/examples/watch-another-namespace/rco-ns2/role3.yaml renamed to internal/deploy/kustomize/daily/examples/watch-another-namespace/rco-ns2/rco-leader-election-rolebinding.yaml

File renamed without changes.

internal/deploy/kustomize/daily/examples/watch-another-namespace/rco-ns2/role2.yaml renamed to internal/deploy/kustomize/daily/examples/watch-another-namespace/rco-ns2/rco-manager-role.yaml

File renamed without changes.

internal/deploy/kustomize/daily/examples/watch-another-namespace/rco-ns2/role4.yaml renamed to internal/deploy/kustomize/daily/examples/watch-another-namespace/rco-ns2/rco-manager-rolebinding.yaml

File renamed without changes.

internal/deploy/kustomize/daily/examples/watch-another-namespace/rco-watched-ns2/kustomization.yaml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ namespace: rco-watched-ns2
66
resources:
77
- ../../../overlays/watch-another-namespace/rco-watched-ns
88
patches:
9-
- path: role1.yaml
10-
- path: role2.yaml
11-
- path: role3.yaml
12-
- path: role4.yaml
9+
- path: rco-watched-role.yaml
10+
- path: rco-watched-rolebinding.yaml
11+
- path: rco-leader-election-watched-role.yaml
12+
- path: rco-leader-election-watched-rolebinding.yaml

internal/deploy/kustomize/daily/examples/watch-another-namespace/rco-watched-ns2/role3.yaml renamed to internal/deploy/kustomize/daily/examples/watch-another-namespace/rco-watched-ns2/rco-leader-election-watched-role.yaml

File renamed without changes.

0 commit comments

Comments
 (0)