Fix codesmell in tests

Author: mialeska

src/test/java/tests/visualization/ImageComparatorTests.java

@@ -69,10 +69,10 @@ public void testGetPercentageDifferenceForDifferentElementsWithFullThreshold() {
     }
 
     @Test
-    public void testGetPercentageDifferenceForSimilarElements() throws InterruptedException {
+    public void testGetPercentageDifferenceForSimilarElements() {
         startLoading();
         Image firstImage = getLoadingImage();
-        Thread.sleep(300);
+        DynamicLoadingForm.waitUntilLoaderChanged(firstImage.getHeight(null));
         Image secondImage = getLoadingImage();
 
         Assert.assertTrue(imageComparator.percentageDifference(firstImage, secondImage, 0) != 0,

src/test/java/tests/visualization/VisualStateProviderTests.java

@@ -2,11 +2,9 @@
 
 import aquality.selenium.core.visualization.IVisualStateProvider;
 import aquality.selenium.core.visualization.ImageFunctions;
-import aquality.selenium.core.waitings.IConditionalWait;
 import org.testng.Assert;
 import org.testng.annotations.BeforeMethod;
 import org.testng.annotations.Test;
-import tests.applications.browser.AqualityServices;
 import tests.applications.browser.ITheInternetPageTest;
 import theinternet.DynamicLoadingForm;
 import theinternet.TheInternetPage;
@@ -80,11 +78,10 @@ public void testGetPercentageDifferenceForDifferentElementsWithFullThreshold() {
     }
 
     @Test
-    public void testGetPercentageDifferenceForSimilarElements() throws InterruptedException {
+    public void testGetPercentageDifferenceForSimilarElements() {
         startLoading();
         Image firstImage = getLoadingVisual().getImage();
-        AqualityServices.get(IConditionalWait.class).waitFor(
-                () -> firstImage.getHeight(null) < getLoadingVisual().getSize().getHeight());
+        DynamicLoadingForm.waitUntilLoaderChanged(firstImage.getHeight(null));
         Assert.assertNotEquals(getLoadingVisual().getDifference(firstImage, 0), 0);
         Assert.assertTrue(getLoadingVisual().getDifference(firstImage, 0.2f) <= 0.3);
         Assert.assertTrue(getLoadingVisual().getDifference(firstImage, 0.4f) <= 0.2);

src/test/java/theinternet/DynamicLoadingForm.java

@@ -3,7 +3,9 @@
 import aquality.selenium.core.applications.IApplication;
 import aquality.selenium.core.elements.ElementState;
 import aquality.selenium.core.elements.interfaces.IElementStateProvider;
+import aquality.selenium.core.waitings.IConditionalWait;
 import org.openqa.selenium.By;
+import tests.applications.browser.AqualityServices;
 import tests.applications.browser.CachedLabel;
 
 import java.time.Duration;
@@ -48,4 +50,9 @@ public IElementStateProvider loaderState() {
     public IElementStateProvider startButtonState() {
         return state(START_BUTTON_LOCATOR);
     }
+
+    public static void waitUntilLoaderChanged(int oldHeight) {
+        AqualityServices.get(IConditionalWait.class).waitFor(
+                () -> oldHeight < getLoadingLabel().visual().getSize().getHeight());
+    }
 }