Missing Parameters in API Request

[Repsay]

Issue: Missing Parameters in API Request

The API no longer accepts the following parameters in the request:

• previousAdvices: prev_advices
• nextAdvices: next_advices

This change leads to unexpected behavior when loading trip data. Without these parameters, it is unclear how to properly request trips that differentiate between past and future departures.

Current Workaround:

I am currently checking whether the first object in the returned list occurs before the requested travel time. If it does, I discard it, as my use case only requires future departures. However, this is a temporary solution and may not be reliable.

Problem:

I am unsure how this issue should be addressed with the current API implementation. If there are alternative parameters or a new method for achieving this functionality, please provide clarification or update the documentation.

Steps to Reproduce:

1. Make a request to the API without the previousAdvices and nextAdvices parameters (since they are no longer supported).
2. Observe the inability to differentiate between past and future departures in the response.
3. Attempt to filter departures based on the requested travel time.

Expected Behavior:

The API should:

1. Continue supporting the previousAdvices and nextAdvices parameters, or
2. Provide alternative parameters or guidance for filtering past and future trips effectively.

Additional Context:

This issue affects applications that require precise filtering of departures for trip planning purposes.

[aquatix]

Oh fun, I wasn't aware they deprecated those parameters. The results sound suboptimal indeed.

I'll try looking at it on Sunday, but will have to dig through the API specs to see what changed and what's the new recommended way of querying. I'll certainly keep your use case of "only future trips" in mind, as it is a very valid and often used one.

Thanks for the detailed feedback!

[aquatix]

Hey, coming back to you after all this time; I am a bit confused by your "Expected Behavior" remark about the API needing to continue supporting those parameters. The NS API is beyond my powers to change, so I cannot do anything about it, I just wrote this library to query it.

Maybe I read this bug report incorrectly; did you mean that the ns-api library does not support those parameters anymore, but the API provided by the Dutch Railways still does? In that case it is a regression in the code here of course, and it should be fixed.

Could you please clarify? Thanks!