fix division by zero

Author: mrfyda

lib/impl/lcov.js

@@ -1,4 +1,4 @@
-(function (lcovParse, Q, Joi, logger, path) {
+(function (lcovParse, Q, Joi, logger, util, path) {
     'use strict';
     var lcovStringValidation = Joi.string().required(),
         optionsValidation = Joi.object().keys().optional();
@@ -45,7 +45,9 @@
                         totalHits += stats.lines.hit;
 
                         // The API uses integers only, so convert accordingly.
-                        fileStats.total = Math.floor((stats.lines.hit / stats.lines.found) * 100);
+                        console.log("pilas" + stats.lines.hit + '/' + stats.lines.found);
+
+                        fileStats.total = Math.floor(util.safeDivision(stats.lines.hit, stats.lines.found) * 100);
 
                         //TODO: Convert to reduce function
                         stats.lines.details.forEach(function (detail) {
@@ -61,7 +63,7 @@
                     });
 
                     // The API uses integers only, so convert accordingly.
-                    result.total = Math.floor((totalHits / totalLines) * 100);
+                    result.total = Math.floor(util.safeDivision(totalHits, totalLines) * 100);
 
                     logger.debug('Successfully Parsed Lcov Data');
 
@@ -71,4 +73,4 @@
             return deferred.promise;
         }
     };
-}(require('lcov-parse'), require('q'), require('joi'), require('../logger')(), require('path')));
+}(require('lcov-parse'), require('q'), require('joi'), require('../logger')(), require('../util'), require('path')));

lib/util.js

@@ -0,0 +1,14 @@
+(function () {
+    'use strict';
+
+    module.exports = {
+        safeDivision: function (numerator, denominator) {
+            if (denominator === 0 || isNaN(denominator)) {
+                return 0;
+            } else {
+                return numerator / denominator;
+            }
+        }
+    };
+
+})();