Skip to content
This repository was archived by the owner on Feb 19, 2020. It is now read-only.

Commit ae0a7ec

Browse files
authored
Merge pull request #64 from mrfyda/master
Don't depend on jest exit code
2 parents 149e9c2 + 07b31bb commit ae0a7ec

File tree

4 files changed

+407
-406
lines changed

4 files changed

+407
-406
lines changed

README.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -145,6 +145,8 @@ npm run test-with-coverage
145145

146146
* Add test with coverage step to your package.json:
147147

148+
Note: [jest might return exit code 1](https://github.com/facebook/jest/issues/3520) if you defined a coverage threshold and the threshold is not met
149+
148150
```json
149151
"scripts": {
150152
"test-with-coverage": "jest --coverage && cat ./coverage/lcov.info | codacy-coverage"

circle.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@ test:
44
- nvm install 7.10.1 && npm run test
55
- nvm install 8.9.4 && npm run test
66
post:
7-
- nvm install 9.6.1
8-
- nvm alias default v9.6.1
7+
- nvm install 10.7.0
8+
- nvm alias default v10.7.0
99
- nvm use default
1010
- npm run test-all
1111
- chmod +x ./bin/codacy-coverage.js

0 commit comments

Comments
 (0)