Merge pull request #12 from codacy/fix-by-zero-division

Fix by zero division

Author: Rodrigo Fernandes

lib/impl/lcov.js

@@ -1,4 +1,4 @@
-(function (lcovParse, Promise, Joi, logger, path) {
+(function (lcovParse, Promise, Joi, logger, util, path) {
     'use strict';
 
     var lcovStringValidation = Joi.string().required();
@@ -10,8 +10,8 @@
                 logger.debug('Parsing Lcov Data');
                 var validLcov = Joi.validate(lcovString, lcovStringValidation);
                 var validOptions = Joi.validate(options, optionsValidation, {
-                        stripUnknown: true
-                    });
+                    stripUnknown: true
+                });
                 var validationError = validLcov.error || validOptions.error;
 
                 if (validationError) {
@@ -28,9 +28,9 @@
                     }
 
                     var result = {
-                            total: 0,
-                            fileReports: []
-                        };
+                        total: 0,
+                        fileReports: []
+                    };
                     var totalLines = 0;
                     var totalHits = 0;
 
@@ -46,7 +46,7 @@
                         totalHits += stats.lines.hit;
 
                         // The API uses integers only, so convert accordingly.
-                        fileStats.total = Math.floor((stats.lines.hit / stats.lines.found) * 100);
+                        fileStats.total = Math.floor(util.safeDivision(stats.lines.hit, stats.lines.found) * 100);
 
                         //TODO: Convert to reduce function
                         stats.lines.details.forEach(function (detail) {
@@ -62,7 +62,7 @@
                     });
 
                     // The API uses integers only, so convert accordingly.
-                    result.total = Math.floor((totalHits / totalLines) * 100);
+                    result.total = Math.floor(util.safeDivision(totalHits, totalLines) * 100);
 
                     logger.debug('Successfully Parsed Lcov Data');
 
@@ -71,4 +71,4 @@
             });
         }
     };
-}(require('lcov-parse'), require('bluebird'), require('joi'), require('../logger')(), require('path')));
+}(require('lcov-parse'), require('bluebird'), require('joi'), require('../logger')(), require('../util'), require('path')));

lib/util.js

@@ -0,0 +1,14 @@
+(function () {
+    'use strict';
+
+    module.exports = {
+        safeDivision: function (numerator, denominator) {
+            if (denominator === 0 || isNaN(denominator)) {
+                return 0;
+            } else {
+                return numerator / denominator;
+            }
+        }
+    };
+
+})();

test/lcov.js

@@ -93,12 +93,12 @@
             return expect(parser.getParser('lcov').parse('', noStatsLcovData))
                 .to.eventually.satisfy(function (data) {
                     expect(JSON.stringify(data)).to.equal(JSON.stringify({
-                        total: null,
+                        total: 0,
                         fileReports: [
                             {
                                 filename: path.normalize('lib/reporter.js'),
                                 coverage: {},
-                                total: null
+                                total: 0
                             }
                         ]
                     }));
@@ -109,12 +109,12 @@
             return expect(parser.getParser('lcov').parse('', nadaLcovData))
                 .to.eventually.satisfy(function (data) {
                     expect(JSON.stringify(data)).to.equal(JSON.stringify({
-                        total: null,
+                        total: 0,
                         fileReports: [
                             {
                                 filename: '',
                                 coverage: {},
-                                total: null
+                                total: 0
                             }
                         ]
                     }));