Merge pull request #34 from codacy/FT-3155

Add zero lines to coverage reports

Author: rtfpessoa

src/Codacy/Coverage/Parser/CloverParser.php

@@ -108,7 +108,7 @@ private function getLineCoverage(\SimpleXMLElement $node)
         foreach ($node as $line) {
             $count = intval($line['count']);
             // iterate all lines in that file
-            if ($line['type'] == 'stmt' && $count > 0) {
+            if ($line['type'] == 'stmt') {
                 $lineNr = (string)$line['num'];
                 $hit = $count;
                 $lineCoverage->$lineNr = $hit;

src/Codacy/Coverage/Parser/PhpUnitXmlParser.php

@@ -82,13 +82,10 @@ private function getLineCoverage(\SimpleXMLElement $node)
         if ($node->file->coverage) {
             foreach ($node->file->coverage->line as $line) {
                 $count = $line->covered->count();
-                if ($count > 0) {
-                    $nr = (string)$line["nr"];
-                    $lineCoverage->$nr = $count;
-                }
+                $nr = (string)$line["nr"];
+                $lineCoverage->$nr = $count;
             }
         }
-        // else there is no line coverage, return empty array then.
         return $lineCoverage;
     }
 

tests/Codacy/Coverage/Parser/CloverParserTest.php

@@ -52,7 +52,8 @@ private function _canParseClover($path, $rootDir)
         $fileReports = $report->getFileReports();
         $fileReport = $fileReports[1];
 
-        $expLineCoverage = (object)array(11 => 1, 12 => 1, 13 => 1, 16 => 1);
+        $expLineCoverage = (object)array(11 => 1, 12 => 1, 13 => 1, 16 => 1,
+            19 => 0, 30 => 0, 31 => 0, 32 => 0, 33 => 0, 36 => 0, 39 => 0, 42 => 0);
         $this->assertEquals($fileReport->getLineCoverage(), $expLineCoverage);
 
         $this->assertEquals("src/Codacy/Coverage/Parser/Parser.php", $parserFileName);

tests/res/expected.json

@@ -25,6 +25,8 @@
         "69": 3,
         "70": 3,
         "71": 3,
+        "72": 0,
+        "73": 0,
         "74": 3,
         "76": 3,
         "77": 3,
@@ -84,6 +86,9 @@
         "56": 2,
         "57": 2,
         "58": 2,
+        "59": 0,
+        "60": 0,
+        "61": 0,
         "64": 2,
         "65": 2,
         "66": 2,
@@ -142,6 +147,9 @@
         "25": 1,
         "26": 1,
         "27": 1,
+        "28": 0,
+        "30": 0,
+        "31": 0,
         "34": 1,
         "41": 1,
         "42": 1

tests/res/phpunit-clover/Parser/CloverParser.php.xml

@@ -113,6 +113,8 @@
         <covered by="CloverParserTest::testCanParseCloverXmlWithProject"/>
         <covered by="Codacy\Coverage\Parser\ParserTest::testParsersProduceSameResult"/>
       </line>
+      <line nr="72" />
+      <line nr="73" />
       <line nr="74">
         <covered by="CloverParserTest::testCanParseCloverXmlWithoutProject"/>
         <covered by="CloverParserTest::testCanParseCloverXmlWithProject"/>

tests/res/phpunit-clover/Parser/PhpUnitXmlParser.php.xml

@@ -71,6 +71,9 @@
         <covered by="Codacy\Coverage\Parser\ParserTest::testParsersProduceSameResult"/>
         <covered by="PhpUnitXmlParserTest::testCanParsePhpUnitXmlReport"/>
       </line>
+      <line nr="59"/>
+      <line nr="60"/>
+      <line nr="61"/>
       <line nr="64">
         <covered by="Codacy\Coverage\Parser\ParserTest::testParsersProduceSameResult"/>
         <covered by="PhpUnitXmlParserTest::testCanParsePhpUnitXmlReport"/>

tests/res/phpunit-clover/Util/GitClient.php.xml

@@ -24,6 +24,9 @@
       <line nr="27">
         <covered by="GitClientTest::testGetHashOfLastCommit"/>
       </line>
+      <line nr="28"/>
+      <line nr="30"/>
+      <line nr="31"/>
       <line nr="34">
         <covered by="GitClientTest::testGetHashOfLastCommit"/>
       </line>