fix: do not set ZEPHYR_SDK_INSTALL_DIR in the workflow

The SDK is now automatically chosen, installed and detected by the
scripts. This hardcoded path was causing issues with readelf not
being found anymore.

Also, this was hiding the fact that the environment was being activated
too late in the workflow, requiring the user to manually source the
venv/bin/activate script or have the ZEPHYR_SDK_INSTALL_DIR variable
in the environment.

Author: pillo79

.github/workflows/package_core.yml

@@ -10,7 +10,6 @@ jobs:
     name: Build and package core
     runs-on: ubuntu-latest
     env:
-      ZEPHYR_SDK_INSTALL_DIR: /opt/zephyr-sdk-0.16.8
       CCACHE_IGNOREOPTIONS: -specs=*
     outputs:
       CORE_TAG: ${{ env.CORE_TAG }}

extra/build.sh

@@ -2,6 +2,10 @@
 
 set -e
 
+source venv/bin/activate
+
+ZEPHYR_BASE=$(west topdir)/zephyr
+
 if [ x$ZEPHYR_SDK_INSTALL_DIR == x"" ]; then
 	SDK_PATH=$(west sdk list | grep path | tail -n 1 | cut -d ':' -f 2 | tr -d ' ')
 	if [ x$SDK_PATH == x ]; then
@@ -50,10 +54,6 @@ fi
 echo
 echo "Build target: $target $args"
 
-source venv/bin/activate
-
-ZEPHYR_BASE=$(west topdir)/zephyr
-
 # Get the variant name (NORMALIZED_BOARD_TARGET in Zephyr)
 variant=$(extra/get_variant_name.sh $target)