feature: add --force flag

Add `--force` flag to forcefully terminate the app in case it's running,
and then clean the related cache.

Author: alessio-perugini

cmd/arduino-app-cli/cache/clean.go

@@ -8,13 +8,15 @@ import (
 
 	cmdApp "github.com/arduino/arduino-app-cli/cmd/arduino-app-cli/app"
 	"github.com/arduino/arduino-app-cli/cmd/arduino-app-cli/completion"
+	"github.com/arduino/arduino-app-cli/cmd/arduino-app-cli/internal/servicelocator"
 	"github.com/arduino/arduino-app-cli/cmd/feedback"
 	"github.com/arduino/arduino-app-cli/internal/orchestrator"
 	"github.com/arduino/arduino-app-cli/internal/orchestrator/app"
 	"github.com/arduino/arduino-app-cli/internal/orchestrator/config"
 )
 
 func newCacheCleanCmd(cfg config.Configuration) *cobra.Command {
+	var forceClean bool
 	appCmd := &cobra.Command{
 		Use:   "clean",
 		Short: "Delete app cache",
@@ -26,16 +28,23 @@ func newCacheCleanCmd(cfg config.Configuration) *cobra.Command {
 			if err != nil {
 				return err
 			}
-			return cacheCleanHandler(cmd.Context(), app)
+			return cacheCleanHandler(cmd.Context(), app, forceClean)
 		},
 		ValidArgsFunction: completion.ApplicationNames(cfg),
 	}
+	appCmd.Flags().BoolVarP(&forceClean, "force", "", false, "Forcefully clean the cache even if the app is running")
 
 	return appCmd
 }
 
-func cacheCleanHandler(ctx context.Context, app app.ArduinoApp) error {
-	if err := orchestrator.CleanAppCache(ctx, app); err != nil {
+func cacheCleanHandler(ctx context.Context, app app.ArduinoApp, forceClean bool) error {
+	err := orchestrator.CleanAppCache(
+		ctx,
+		servicelocator.GetDockerClient(),
+		app,
+		orchestrator.CleanAppCacheRequest{ForceClean: forceClean},
+	)
+	if err != nil {
 		feedback.Fatal(err.Error(), feedback.ErrGeneric)
 	}
 	feedback.PrintResult(cacheCleanResult{

internal/orchestrator/cache.go

@@ -2,16 +2,39 @@ package orchestrator
 
 import (
 	"context"
+	"errors"
+
+	"github.com/docker/cli/cli/command"
 
 	"github.com/arduino/arduino-app-cli/internal/orchestrator/app"
 )
 
+type CleanAppCacheRequest struct {
+	ForceClean bool
+}
+
+var ErrCleanCacheRunningApp = errors.New("cannot remove cache of a running app")
+
 // CleanAppCache removes the `.cache` folder. If it detects that the app is running
 // it tries to stop it first.
-func CleanAppCache(ctx context.Context, app app.ArduinoApp) error {
-	if app.AppComposeFilePath().Exist() {
+func CleanAppCache(
+	ctx context.Context,
+	docker command.Cli,
+	app app.ArduinoApp,
+	req CleanAppCacheRequest,
+) error {
+	runningApp, err := getRunningApp(ctx, docker.Client())
+	if err != nil {
+		return err
+	}
+	if runningApp.FullPath.EqualsTo(app.FullPath) {
+		return ErrCleanCacheRunningApp
+	}
+
+	if req.ForceClean && app.AppComposeFilePath().Exist() {
 		// We try to remove docker related resources at best effort
 		_ = StopAndDestroyApp(ctx, app)
 	}
+
 	return app.ProvisioningStateDir().RemoveAll()
 }