apt.Search improvements:

- Wrap search param with *
- Don't raise errors when no packages are found

Signed-off-by: Matteo Suppo <matteo.suppo@gmail.com>

Author: matteosuppo

apt.go

@@ -44,13 +44,19 @@ func List() ([]*Package, error) {
 // Search list packages available in the system that match the search
 // pattern
 func Search(pattern string) ([]*Package, error) {
-	cmd := exec.Command("dpkg-query", "-W", "-f=${Package}\t${Architecture}\t${db:Status-Status}\t${Version}\n", pattern)
-	out, err := cmd.Output()
+	res := []*Package{}
+
+	cmd := exec.Command("dpkg-query", "-W", "-f=${Package}\t${Architecture}\t${db:Status-Status}\t${Version}\n", "*"+pattern+"*")
+
+	out, err := cmd.CombinedOutput()
 	if err != nil {
-		return nil, fmt.Errorf("running dpkg-query: %s", err)
+		// Avoid returning an error if the list is empty
+		if bytes.Contains(out, []byte("no packages found matching")) {
+			return res, nil
+		}
+		return nil, fmt.Errorf("running dpkg-query: %s - %s", err, out)
 	}
 
-	res := []*Package{}
 	scanner := bufio.NewScanner(bytes.NewReader(out))
 	for scanner.Scan() {
 		data := strings.Split(scanner.Text(), "\t")

apt_test.go

@@ -38,18 +38,28 @@ func TestList(t *testing.T) {
 			continue
 		}
 		statusCount[p.Status]++
-		fmt.Printf("%+v\n", p)
+		// fmt.Printf("%+v\n", p)
 	}
 
-	fmt.Println("Summary:")
-	for k, v := range statusCount {
-		fmt.Printf("  %s: %d\n", k, v)
-	}
+	// fmt.Println("Summary:")
+	// for k, v := range statusCount {
+	// 	fmt.Printf("  %s: %d\n", k, v)
+	// }
 
 	require.NotNil(t, dpkg, "search package 'dpkg'")
 	require.Equal(t, "installed", dpkg.Status, "'dpkg' status")
 }
 
+func TestSearch(t *testing.T) {
+	list, err := Search("nonexisting")
+	require.NoError(t, err, "running Search command")
+	require.Empty(t, list, "Search command result")
+
+	list, err = Search("header")
+	require.NoError(t, err, "running Search command")
+	require.NotEmpty(t, list, "Search command result")
+}
+
 func TestListUpgradable(t *testing.T) {
 	list, err := ListUpgradable()
 	for _, p := range list {