From a5031f3b4276babd8ed5b1bda87d846cd84f6dfb Mon Sep 17 00:00:00 2001
From: Pete R Jemian <prjemian@gmail.com>
Date: Wed, 1 Jan 2025 08:43:39 -0600
Subject: [PATCH 1/3] MNT #512 add suggested support

---
 XML_schema/NDAttributes.xsd | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/XML_schema/NDAttributes.xsd b/XML_schema/NDAttributes.xsd
index 80209ccc1..101f221ff 100644
--- a/XML_schema/NDAttributes.xsd
+++ b/XML_schema/NDAttributes.xsd
@@ -189,13 +189,15 @@
       BUT, cannot express "<" in XML, must use &lt; but that won't parse!
       So, use use a reduced (but very likely) subset of rules.  
       Do not allow these symbols: []<>
+
+      To support macro expansion, support these symbols: $ ( )
     -->
     <xs:union memberTypes="type_EPICS_PV_source type_PARAM_source"/>
   </xs:simpleType>
   
   <xs:simpleType name="type_EPICS_PV_source">
-    <xs:restriction base="xs:NMTOKEN">
-      <xs:pattern value="[\w_\-:.;]+([.][A-Z0-9]+)?"/>
+    <xs:restriction base="xs:string">
+      <xs:pattern value="[\w_\-:.;\$\(\)]+([.][A-Z0-9]+)?"/>
     </xs:restriction>
   </xs:simpleType>
   

From b8125b0b3c9a9d68f3e4684b2c7bc89cce273f0a Mon Sep 17 00:00:00 2001
From: Pete R Jemian <prjemian@gmail.com>
Date: Wed, 1 Jan 2025 08:44:02 -0600
Subject: [PATCH 2/3] DOC #512 add example with macros

---
 XML_schema/example_attributes.xml | 15 +++++++++++++++
 1 file changed, 15 insertions(+)
 create mode 100755 XML_schema/example_attributes.xml

diff --git a/XML_schema/example_attributes.xml b/XML_schema/example_attributes.xml
new file mode 100755
index 000000000..899de743f
--- /dev/null
+++ b/XML_schema/example_attributes.xml
@@ -0,0 +1,15 @@
+<?xml version="1.0" standalone="no" ?>
+<!-- Attributes -->
+<Attributes
+    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+    xsi:noNamespaceSchemaLocation="https://github.com/areaDetector/ADCore/blob/master/iocBoot/NDAttributes.xsd"
+    >
+    <Attribute name="AcquireTime"         type="EPICS_PV" source="13SIM1:cam1:AcquireTime"      dbrtype="DBR_NATIVE"  description="Camera acquire time"/>
+    <Attribute name="ImageCounter"        type="PARAM"    source="ARRAY_COUNTER"                datatype="INT"        description="Image counter"/>
+    <Attribute name="calc1_val"           type="EPICS_PV" source="$(P)userCalc1.VAL"            dbrtype="DBR_NATIVE" description="some calculation result"/>
+    <Attribute name="calc2_val"           type="EPICS_PV" source="$(P)userCalc2.VAL"            dbrtype="DBR_NATIVE" description="another calculation result"/>
+    <Attribute name="MaxSizeX"            type="PARAM"    source="MAX_SIZE_X"                   datatype="INT"        description="Detector X size"/>
+    <Attribute name="MaxSizeY"            type="PARAM"    source="MAX_SIZE_Y"                   datatype="INT"        description="Detector Y size"/>
+    <Attribute name="CameraModel"         type="PARAM"    source="MODEL"                        datatype="STRING"     description="Camera model"/>
+    <Attribute name="CameraManufacturer"  type="PARAM"    source="MANUFACTURER"                 datatype="STRING"     description="Camera manufacturer"/>
+</Attributes>

From 7667643cd55797b1442afdc14372e58abc5008bd Mon Sep 17 00:00:00 2001
From: Pete R Jemian <prjemian@gmail.com>
Date: Wed, 1 Jan 2025 08:45:28 -0600
Subject: [PATCH 3/3] DOC #512 move docstring, it's just for EPICS PVs

---
 XML_schema/NDAttributes.xsd | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/XML_schema/NDAttributes.xsd b/XML_schema/NDAttributes.xsd
index 101f221ff..75da25a60 100644
--- a/XML_schema/NDAttributes.xsd
+++ b/XML_schema/NDAttributes.xsd
@@ -179,6 +179,10 @@
   </xs:simpleType>
   
   <xs:simpleType name="type_source">
+    <xs:union memberTypes="type_EPICS_PV_source type_PARAM_source"/>
+  </xs:simpleType>
+  
+  <xs:simpleType name="type_EPICS_PV_source">
     <!-- EPICS PV name rules
       see: http://www.aps.anl.gov/epics/wiki/index.php/RRM_3-14_Concepts#Database_Addresses
       The record name can be a mix of the following: 
@@ -192,10 +196,6 @@
 
       To support macro expansion, support these symbols: $ ( )
     -->
-    <xs:union memberTypes="type_EPICS_PV_source type_PARAM_source"/>
-  </xs:simpleType>
-  
-  <xs:simpleType name="type_EPICS_PV_source">
     <xs:restriction base="xs:string">
       <xs:pattern value="[\w_\-:.;\$\(\)]+([.][A-Z0-9]+)?"/>
     </xs:restriction>