Skip to content

Temperature and humidity update for channel 3 updates channel 0 #19

@ArmandoPueyos

Description

@ArmandoPueyos

setDoubleParam(PilatusThTemp0, temp);

When reading detector temp and humidity, there is an entry for Channel 3 that is unlikely to exist. And worse, if it exists it overrides Channel 0:

    if ((substr = strstr(this->fromCamserver, "Channel 3")) != NULL) {
        sscanf(substr, "Channel 3: Temperature = %fC, Rel. Humidity = %f", &temp, &humid);
        setDoubleParam(PilatusThTemp0, temp);
        setDoubleParam(PilatusThHumid0, humid);
    }

IMHO I believe this piece of code should be removed to avoid confusion.
However, I ignore if there is a case of Pilatus systems where the channels are numbered [1..3] instead of [0..2] by CamServer -- if that's the case then it should be properly documented, and set ADTemperature as well.

Thanks,
Armando

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions