Parametric Stereo

[tsalisbury0]

It seems like HDRadio has Parametric Stereo on some of the sub channels now as well as on MA3 mode. Would be nice to have that an option to be enabled or disabled on the HDC encoder as well as a selection of bitrates instead of typing out a number to find the maximum bitrate.

[argilo]

Please open a separate issue for each bug or feature request.

[tsalisbury0]

Please open a separate issue for each bug or feature request.

Yep doing that now. Not used to GitHub issue reporting yet.

[argilo]

Parametric stereo decoding support was added to nrsc5 in theori-io/nrsc5#285, so I suppose it might be possible to add encoding support in gr-nrsc5. But I don't understand the codec very well and so I've been hesitant to touch it. Perhaps someone else would be interested in taking a crack at it someday.

[Sussyman2-0]

Parametric stereo decoding support was added to nrsc5 in theori-io/nrsc5#285, so I suppose it might be possible to add encoding support in gr-nrsc5. But I don't understand the codec very well and so I've been hesitant to touch it. Perhaps someone else would be interested in taking a crack at it someday.

Yes! ive been able to repatch the latest FDK-AAC v2.0.3 https://github.com/mstorsjo/fdk-aac/releases/tag/v2.0.3

i repatched because the current AAC encoder sounds poor, and im working on Parametric stereo now! i will have my patches set up on my github! @argilo if you eventually take a crack at it, there are a few changes...

the older FDK did not enforce rules to fallback (aka, just shutting off the "broken" AOTs). so the first patch was easy.. now you have to enforce everything add new headers and variables

the old patch, i believe all you needed to do is add explicit definitions and the timing changes, as well as different headers.

#define AOT_HDC 127 #define AOT_HDC_PS 128
(i kept your patch AOT defs so even this PS enabled FDK-AAC lib can be used with the original gr-nrsc5)

but NOW you have to enforce all the rules and tools. its quite annoying... im still trying to get AOT 128 to be not be shut off.. there are so many little checks. and basically redesigning PS with the time difference (32 vs 30) its fun!

i have forked gr-nrsc5 and added a selector in the HDC encoder block that allows you to select Stereo or Parametric Stereo via dropdown.

(i am still new to Github, so lots of this is new to me, but I am a fan of HD Radio and im excited i can finally transmit with it! I appreciate the effort you made patching HDC and building this program!!)

[tsalisbury0]

@Sussyman2-0 Have you been able to get your patch to run?

[Sussyman2-0]

@Sussyman2-0 Have you been able to get your patch to run?

I am currently half way testing, but the standard AOT 127 is working fine. But FDK is even more strict when you try to enable Parametric Stereo, I keep getting the error "Unable to set the AOT"... I am working on it, but standard HDC sounds so much better bc of the newer FDK version...

24kbps is bearable with the new FDK... especially 32-30kbps is much better than the actual HD radio HDC encoders on commercial stations.

I will post everything working on my github once I get it built and working!

[TheDaChicken]

It may also be helpful to look at the patch for faad2 in the main nrsc5 repo if you haven't already. PS for HDC is similar to DRM PS.

[tsalisbury0]

@Sussyman2-0 Have you been able to get your patch to run?

I am currently half way testing, but the standard AOT 127 is working fine. But FDK is even more strict when you try to enable Parametric Stereo, I keep getting the error "Unable to set the AOT"... I am working on it, but standard HDC sounds so much better bc of the newer FDK version...

24kbps is bearable with the new FDK... especially 32-30kbps is much better than the actual HD radio HDC encoders on commercial stations.

I will post everything working on my github once I get it built and working!

How do I get the new FDK in the current GR-NRSC5?

[Sussyman2-0]

I am now running into new errors... the flowgraph seems to freeze but I redid my environment and working out issues...

[Sussyman2-0]

It may also be helpful to look at the patch for faad2 in the main nrsc5 repo if you haven't already. PS for HDC is similar to DRM PS.

Thank you so much! This will be a great help as every time I try to get PS on AOT 128, it always throws the error that it cannot be set... makes me mad.. but this should help me along greatly. Thank you!

[secludedhusky]

It may also be helpful to look at the patch for faad2 in the main nrsc5 repo if you haven't already. PS for HDC is similar to DRM PS.

Thank you so much! This will be a great help as every time I try to get PS on AOT 128, it always throws the error that it cannot be set... makes me mad.. but this should help me along greatly. Thank you!

I'm interested in helping you out with the implementation of all of this. It'd be nice if you could provide me access to your commits as well as what you've gotten so far, since a lot of your work is currently missing from your Github forks.

I have a feeling with the two of us, we could figure it out very quickly. If you could drop me your Discord so that we could work on it together, that'd be awesome.

I'm excited to potentially help out with this and I look forward to getting this implemented.

[Sussyman2-0]

It may also be helpful to look at the patch for faad2 in the main nrsc5 repo if you haven't already. PS for HDC is similar to DRM PS.

Thank you so much! This will be a great help as every time I try to get PS on AOT 128, it always throws the error that it cannot be set... makes me mad.. but this should help me along greatly. Thank you!

I'm interested in helping you out with the implementation of all of this. It'd be nice if you could provide me access to your commits as well as what you've gotten so far, since a lot of your work is currently missing from your Github forks.

I have a feeling with the two of us, we could figure it out very quickly. If you could drop me your Discord so that we could work on it together, that'd be awesome.

I'm excited to potentially help out with this and I look forward to getting this implemented.

yes, i havent been pusing alot towards my github as im new to it, and i am developing and doing everything locally for the time being, but i will be glad!

yes ofc! my discord is "jimmydeansuasages" exactly

i am excited as well, thank you!