next: Activating `serialize` feature on `async-stripe-webhook` results in compile error

[robko23]

Describe the bug

When enabling (de)serialize feature on async-stripe-webhook@next results in compilation error with messages that events don't implement serde::Serialize/serde::Deserialize.

My temporary fix to make it compile is this patch:

diff --git a/async-stripe-webhook/Cargo.toml b/async-stripe-webhook/Cargo.toml
index 44d1a084..6490dd5f 100644
--- a/async-stripe-webhook/Cargo.toml
+++ b/async-stripe-webhook/Cargo.toml
@@ -39,8 +39,31 @@ async-stripe-treasury = { path = "../generated/async-stripe-treasury", optional
 serde_json.workspace = true

 [features]
-serialize = ["async-stripe-types/serialize", "async-stripe-shared/serialize"]
-deserialize = ["async-stripe-types/deserialize", "async-stripe-shared/deserialize", "dep:serde_json"]
+serialize = [
+       "async-stripe-types/serialize",
+       "async-stripe-shared/serialize",
+       "async-stripe-billing/serialize",
+       "async-stripe-checkout/serialize",
+       "async-stripe-core/serialize",
+       "async-stripe-fraud/serialize",
+       "async-stripe-misc/serialize",
+       "async-stripe-payment/serialize",
+       "async-stripe-terminal/serialize",
+       "async-stripe-treasury/serialize",
+]
+deserialize = [
+       "async-stripe-types/deserialize",
+       "async-stripe-shared/deserialize",
+       "dep:serde_json",
+       "async-stripe-billing/deserialize",
+       "async-stripe-checkout/deserialize",
+       "async-stripe-core/deserialize",
+       "async-stripe-fraud/deserialize",
+       "async-stripe-misc/deserialize",
+       "async-stripe-payment/deserialize",
+       "async-stripe-terminal/deserialize",
+       "async-stripe-treasury/deserialize",
+]

but this enables all the optional crates and results in compiling code that I don't use elsewhere.

The solution would need to be in AND fashion, not OR.
Now the resolution works like this:

1. async-stripe-billing is optional and has feature serialize
2. enable async-stripe-billing on async-stripe-webhook -> crate enabled without serialize feature
3. enable serialize on async-stripe-webhook that has dependent feature async-stripe-billing/serialize -> crate also enabled with feature serialize even thought I don't need async-stripe-billing

The ideal solution would work like this:
async-stripe-webhook enables serialize AND async-stripe-billing.
this activates async-stripe-billing/serialize, but not the other crates.

Right now I don't have idea how to solve this, but that could just be my limited experience with cargo features.
If you have an idea how to solve it, I would be more than willing to open a PR to resolve this

To Reproduce

Expected behavior

Code snippets

OS

Linux

Rust version

1.84.0

Library version

next

API version

2024-04-10

Additional context

No response

[mzeitlin11]

Thanks for the report @robko23! I hope to have some time to fix this at some point, but at a quick look does the ? syntax described in https://doc.rust-lang.org/cargo/reference/features.html#dependency-features solve this?

[robko23]

Thanks @mzeitlin11 , I had no idea this syntax existed. I've always been developing apps or private libraries, so I've never came across this.
I openeded PR that fixes this

[robko23]

fixed in already merged pr #667 , idk why this wasn't closed automatically