Skip to content

Commit 20acabf

Browse files
committed
Skip container for simple widgets
1 parent 1191f54 commit 20acabf

File tree

2 files changed

+13
-24
lines changed

2 files changed

+13
-24
lines changed

spec/Arrilot/Widgets/Factories/WidgetFactorySpec.php

Lines changed: 11 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
use App\Widgets\TestDefaultSlider;
88
use App\Widgets\TestMyClass;
99
use App\Widgets\TestRepeatableFeed;
10-
use App\Widgets\TestWidgetWithCustomCssClass;
1110
use App\Widgets\TestWidgetWithDIInRun;
1211
use App\Widgets\TestWidgetWithParamsInRun;
1312
use Arrilot\Widgets\Misc\LaravelApplicationWrapper;
@@ -63,7 +62,7 @@ public function it_can_run_widget_from_default_namespace(LaravelApplicationWrapp
6362
);
6463
$this->testDefaultSlider()
6564
->shouldReturn(
66-
'<div id="arrilot-widget-container-1" style="display:inline" class="arrilot-widget-container">Default test slider was executed with $slides = 6</div>'
65+
'Default test slider was executed with $slides = 6'
6766
);
6867
}
6968

@@ -74,7 +73,7 @@ public function it_can_run_widget_from_custom_namespace(LaravelApplicationWrappe
7473
);
7574
$this->slider()
7675
->shouldReturn(
77-
'<div id="arrilot-widget-container-1" style="display:inline" class="arrilot-widget-container">Slider was executed with $slides = 6</div>'
76+
'Slider was executed with $slides = 6'
7877
);
7978
}
8079

@@ -85,7 +84,7 @@ public function it_provides_config_override(LaravelApplicationWrapper $wrapper)
8584
);
8685
$this->slider(['slides' => 5])
8786
->shouldReturn(
88-
'<div id="arrilot-widget-container-1" style="display:inline" class="arrilot-widget-container">Slider was executed with $slides = 5</div>'
87+
'Slider was executed with $slides = 5'
8988
);
9089
}
9190

@@ -101,7 +100,7 @@ public function it_can_run_widgets_with_additional_params(LaravelApplicationWrap
101100
);
102101
$this->testWidgetWithParamsInRun([], 'asc')
103102
->shouldReturn(
104-
'<div id="arrilot-widget-container-1" style="display:inline" class="arrilot-widget-container">TestWidgetWithParamsInRun was executed with $flag = asc</div>'
103+
'TestWidgetWithParamsInRun was executed with $flag = asc'
105104
);
106105
}
107106

@@ -112,7 +111,7 @@ public function it_can_run_widgets_with_method_injection(LaravelApplicationWrapp
112111
);
113112
$this->testWidgetWithParamsInRun()
114113
->shouldReturn(
115-
'<div id="arrilot-widget-container-1" style="display:inline" class="arrilot-widget-container">bar</div>'
114+
'bar'
116115
);
117116
}
118117

@@ -123,7 +122,7 @@ public function it_can_run_widgets_with_run_method(LaravelApplicationWrapper $wr
123122
);
124123
$this->run('testDefaultSlider')
125124
->shouldReturn(
126-
'<div id="arrilot-widget-container-1" style="display:inline" class="arrilot-widget-container">Default test slider was executed with $slides = 6</div>'
125+
'Default test slider was executed with $slides = 6'
127126
);
128127
}
129128

@@ -134,7 +133,7 @@ public function it_can_run_widgets_with_run_method_and_config_override(LaravelAp
134133
);
135134
$this->run('slider', ['slides' => 5])
136135
->shouldReturn(
137-
'<div id="arrilot-widget-container-1" style="display:inline" class="arrilot-widget-container">Slider was executed with $slides = 5</div>'
136+
'Slider was executed with $slides = 5'
138137
);
139138
}
140139

@@ -145,7 +144,7 @@ public function it_can_run_nested_widgets(LaravelApplicationWrapper $wrapper)
145144
);
146145
$this->run('Profile\TestNamespace\TestFeed', ['slides' => 5])
147146
->shouldReturn(
148-
'<div id="arrilot-widget-container-1" style="display:inline" class="arrilot-widget-container">Feed was executed with $slides = 6</div>'
147+
'Feed was executed with $slides = 6'
149148
);
150149
}
151150

@@ -156,7 +155,7 @@ public function it_can_run_nested_widgets_with_dot_notation(LaravelApplicationWr
156155
);
157156
$this->run('profile.testNamespace.testFeed', ['slides' => 5])
158157
->shouldReturn(
159-
'<div id="arrilot-widget-container-1" style="display:inline" class="arrilot-widget-container">Feed was executed with $slides = 6</div>'
158+
'Feed was executed with $slides = 6'
160159
);
161160
}
162161

@@ -167,15 +166,15 @@ public function it_can_run_multiple_widgets(LaravelApplicationWrapper $wrapper)
167166
);
168167
$this->slider()
169168
->shouldReturn(
170-
'<div id="arrilot-widget-container-1" style="display:inline" class="arrilot-widget-container">Slider was executed with $slides = 6</div>'
169+
'Slider was executed with $slides = 6'
171170
);
172171

173172
$wrapper->call(Argument::any(), Argument::any())->willReturn(
174173
call_user_func_array([new Slider(['slides' => 5]), 'run'], ['slides' => 5])
175174
);
176175
$this->slider(['slides' => 5])
177176
->shouldReturn(
178-
'<div id="arrilot-widget-container-2" style="display:inline" class="arrilot-widget-container">Slider was executed with $slides = 5</div>'
177+
'Slider was executed with $slides = 5'
179178
);
180179
}
181180

@@ -197,17 +196,6 @@ public function it_can_run_async_widget(LaravelApplicationWrapper $wrapper)
197196
);
198197
}
199198

200-
public function it_can_be_configurate_to_use_custom_css_class_in_wrapper(LaravelApplicationWrapper $wrapper)
201-
{
202-
$wrapper->call(Argument::any(), Argument::any())->willReturn(
203-
call_user_func_array([new TestWidgetWithCustomCssClass([]), 'run'], [])
204-
);
205-
$this->run('testWidgetWithCustomCssClass')
206-
->shouldReturn(
207-
'<div id="arrilot-widget-container-1" style="display:inline" class="dummyClass">Dummy Content</div>'
208-
);
209-
}
210-
211199
public function it_can_cache_widgets(LaravelApplicationWrapper $wrapper)
212200
{
213201
$wrapper->call(Argument::any(), Argument::any())->willReturn(

src/Factories/WidgetFactory.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,9 +34,10 @@ public function run()
3434

3535
if ($timeout = $this->getReloadTimeout()) {
3636
$content .= $this->javascriptFactory->getReloader($timeout);
37+
return $this->wrapContentInContainer($content);
3738
}
3839

39-
return $this->wrapContentInContainer($content);
40+
return $content;
4041
}
4142

4243
/**

0 commit comments

Comments
 (0)