BinaryOp handling "=" overlaps with VariableAssignment

[m-akhil-reddy]

Summary

Title: BinaryOp handling "=" overlaps with VariableAssignment

Description:

While exploring assignment handling in IRx, I found that the "=" operator is currently handled inside BinaryOp:

• llvmliteir.py

This logic:

• evaluates RHS expression
• looks up the variable from named_values
• emits a store instruction
• pushes the result to result_stack

A very similar flow exists in visit(VariableAssignment):

• llvmliteir.py

This results in duplicated assignment logic across two different paths.

From the recent discussion, it seems BinaryOp is not expected to handle "=". If that is the case, this behavior may need to be adjusted so that assignment is handled only through VariableAssignment.

Questions:

• Should assignment logic be removed from BinaryOp entirely?
• Should the common assignment logic be centralized/shared?

I’d be happy to work on aligning this with the intended design.

OS / Environment

.

Steps to Reproduce

.

File Upload (optional)

.

Expected Results

.

Actual Results

.

IRx version

.

Code of Conduct

• I agree to follow the Code of Conduct

[m-akhil-reddy]

@yuvimittal , can you assign this issue to me.

[xmnlab]

binary op shouldn't handle "="

[xmnlab]

@m-akhil-reddy could you point me where binaryop is handling "=" please?

[m-akhil-reddy]

@xmnlab ,
Yes, it seems BinaryOp is handling "=" here:

• llvmliteir.py

In this block (when op_code == "="), it:

• evaluates the RHS
• looks up the variable from named_values
• emits a store
• pushes the result to result_stack

A very similar flow exists in:

• visit(VariableAssignment) (llvmliteir.py)

Let me know if this is the expected behavior or if assignment should be handled only via VariableAssignment.