Skip to content

Commit 336b055

Browse files
committed
Fix JaCoCo reports not appearing during CI
1 parent 27eaf51 commit 336b055

File tree

4 files changed

+6
-43
lines changed

4 files changed

+6
-43
lines changed

.github/workflows/build.yml

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ jobs:
120120
# XZ with max compression, more efficient than using GZip.
121121
XZ_OPT=-9 tar -Jcvf reports-${{ matrix.java-version }}-${{ matrix.os-name }}.tar.xz \
122122
$(find . -name surefire-reports -o -name failsafe-reports) \
123-
$(find . -name 'jacoco*.xml')
123+
$(find . -name 'jacoco.xml')
124124

125125
- name: Stash reports tarball
126126
uses: actions/upload-artifact@v3.1.2
@@ -195,10 +195,6 @@ jobs:
195195
shasum -a 256 -c codecov.SHA256SUM
196196
chmod -v +x codecov
197197
./codecov -v
198-
# TODO: upload unit test and integration test reports separately so that
199-
# codecov processes it correctly. Need to hard-wire the paths in here somehow.
200-
#./codecov -c -F unit -v
201-
#./codecov -c -F integration -v
202198
203199
linting:
204200
name: Linting

codecov.yml

Lines changed: 0 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -34,40 +34,3 @@ coverage:
3434
precision: 2
3535
range: "10...100"
3636
round: down
37-
38-
# Feature flags
39-
# TODO: enable when codecov fix this feature, and then readd flags in uploader for build.yml
40-
#flag_management:
41-
# default_rules:
42-
# carryforward: true
43-
# statuses:
44-
# - type: project
45-
# target: auto
46-
# threshold: 1%
47-
# - type: patch
48-
# target: 90%
49-
#
50-
# individual_flags:
51-
# # Unit testing coverage
52-
# - name: unit
53-
# carryforward: true
54-
# paths:
55-
# - '**/target/site/jacoco/unit/jacoco*.xml'
56-
# statuses:
57-
# - type: project
58-
# target: auto
59-
# threshold: 65%
60-
# - type: patch
61-
# target: 90%
62-
#
63-
# # Integration testing coverage
64-
# - name: integration
65-
# carryforward: true
66-
# paths:
67-
# - '**/target/site/jacoco/int/jacoco*.xml'
68-
# statuses:
69-
# - type: project
70-
# target: auto
71-
# threshold: 0%
72-
# - type: patch
73-
# target: 0%

java-compiler-testing/pom.xml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -154,6 +154,11 @@
154154
<groupId>org.apache.maven.plugins</groupId>
155155
<artifactId>maven-surefire-plugin</artifactId>
156156
</plugin>
157+
158+
<plugin>
159+
<groupId>org.jacoco</groupId>
160+
<artifactId>jacoco-maven-plugin</artifactId>
161+
</plugin>
157162
</plugins>
158163
</build>
159164
</project>

pom.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -574,7 +574,6 @@
574574
</pluginManagement>
575575

576576
<plugins>
577-
578577
<plugin>
579578
<groupId>org.apache.maven.plugins</groupId>
580579
<artifactId>maven-enforcer-plugin</artifactId>

0 commit comments

Comments
 (0)