Skip to content

Commit b00c1d4

Browse files
authored
Remove generic arguments from JctCompiler (#489)
Fixes #488 by removing the unused generic arguments in JctCompiler and derived classes. --------- Signed-off-by: ascopes <73482956+ascopes@users.noreply.github.com>
1 parent e01f1d3 commit b00c1d4

File tree

40 files changed

+167
-183
lines changed

40 files changed

+167
-183
lines changed

README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,7 @@ class ExampleTest {
156156

157157
@DisplayName("I can compile a Hello World application")
158158
@JavacCompilerTest
159-
void canCompileHelloWorld(JctCompiler<?, ?> compiler) {
159+
void canCompileHelloWorld(JctCompiler compiler) {
160160
// Given
161161
workspace
162162
.createSourcePathPackage()
@@ -213,7 +213,7 @@ class JsonSchemaAnnotationProcessorTest {
213213
Workspace workspace;
214214

215215
@JavacCompilerTest(minVersion = 11, maxVersion = 21)
216-
void theJsonSchemaIsCreatedFromTheInputCode(JctCompiler<?, ?> compiler) {
216+
void theJsonSchemaIsCreatedFromTheInputCode(JctCompiler compiler) {
217217
// Given
218218
workspace
219219
.createSourcePathPackage()
@@ -262,7 +262,7 @@ class ExampleTest {
262262

263263
@DisplayName("I can compile a module that is using Lombok")
264264
@JavacCompilerTest(modules = true)
265-
void canCompileModuleUsingLombok(JctCompiler<?, ?> compiler) {
265+
void canCompileModuleUsingLombok(JctCompiler compiler) {
266266
try (var workspace = Workspaces.newWorkspace()) {
267267
// Given
268268
workspace

acceptance-tests/acceptance-tests-dogfood/src/test/java/io/github/ascopes/jct/acceptancetests/dogfood/JctCompilationConfigurer.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
public class JctCompilationConfigurer implements JctCompilerConfigurer<RuntimeException> {
2929

3030
@Override
31-
public void configure(JctCompiler<?, ?> compiler) {
31+
public void configure(JctCompiler compiler) {
3232
compiler
3333
.failOnWarnings(false)
3434
.showWarnings(false) // ignore spam about the testing module being hidden

acceptance-tests/acceptance-tests-dogfood/src/test/java/io/github/ascopes/jct/acceptancetests/dogfood/JctDogfoodTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ class JctDogfoodTest {
6565

6666
@DisplayName("JCT can compile itself as a legacy module source")
6767
@JavacCompilerTest(minVersion = 11, configurers = JctCompilationConfigurer.class)
68-
void jctCanCompileItselfAsLegacyModule(JctCompiler<?, ?> compiler) throws IOException {
68+
void jctCanCompileItselfAsLegacyModule(JctCompiler compiler) throws IOException {
6969
// Given
7070
try (var workspace = Workspaces.newWorkspace()) {
7171
workspace
@@ -87,7 +87,7 @@ void jctCanCompileItselfAsLegacyModule(JctCompiler<?, ?> compiler) throws IOExce
8787

8888
@DisplayName("JCT can compile its unit tests as a legacy module source")
8989
@JavacCompilerTest(minVersion = 11, configurers = JctCompilationConfigurer.class)
90-
void jctCanCompileUnitTestsAsLegacyModule(JctCompiler<?, ?> compiler) throws IOException {
90+
void jctCanCompileUnitTestsAsLegacyModule(JctCompiler compiler) throws IOException {
9191
// Given
9292
try (var workspace = Workspaces.newWorkspace()) {
9393
workspace
@@ -109,7 +109,7 @@ void jctCanCompileUnitTestsAsLegacyModule(JctCompiler<?, ?> compiler) throws IOE
109109

110110
@DisplayName("JCT can compile itself and its unit tests as a multiple-module source")
111111
@JavacCompilerTest(minVersion = 11, configurers = JctCompilationConfigurer.class)
112-
void jctCanCompileItselfAndUnitTestsAsMultiModule(JctCompiler<?, ?> compiler) throws IOException {
112+
void jctCanCompileItselfAndUnitTestsAsMultiModule(JctCompiler compiler) throws IOException {
113113
// Given
114114
try (var workspace = Workspaces.newWorkspace()) {
115115
workspace

0 commit comments

Comments
 (0)