Skip to content

Commit e0a8e9f

Browse files
authored
Shelve ECJ support
Signed-off-by: ascopes <73482956+ascopes@users.noreply.github.com>
1 parent 172c20a commit e0a8e9f

File tree

1 file changed

+3
-10
lines changed

1 file changed

+3
-10
lines changed

README.md

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -153,16 +153,9 @@ open module my.tests {
153153

154154
## Support for ECJ (Eclipse Java Compiler)
155155

156-
The Eclipse Java Compiler supports the same standard interface for invoking a Java compiler
157-
that Javac does, which means that _in theory_, the _java-compiler-testing_ library supports
158-
invoking ECJ.
159-
160-
At the time of writing, [GH-163](https://github.com/ascopes/java-compiler-testing/issues/163) tracks the addition of ECJ support to this library. The PR
161-
up at [GH-422](https://github.com/ascopes/java-compiler-testing/pull/422) implements this functionality. However, the most recent releases of ECJ do not
162-
correctly support the detection and handling of modules that appear in the module path, and as a
163-
result, test cases making use of JPMS modules and dependencies do not appear to work
164-
correctly. Once these issues are resolved with Eclipse, or once a suitable workaround is found,
165-
then this PR will be completed and merged.
156+
While ECJ supports the same interfaces as Javac that are used to call the compiler from this library, [eclipse-jdt/eclipse.jdt.core#1153](https://github.com/eclipse-jdt/eclipse.jdt.core/issues/1153) means we will not get functional Java 11 support going forwards.
157+
158+
A number of issues were found while developing [ascopes/java-compiler-testing#163](https://github.com/ascopes/java-compiler-testing/issues/163) with ECJ which prevents many features such as JPMS support from working correctly. Since it is unlikely these issues will be addressed in the near future, support for ECJ has been shelved.
166159

167160
## Examples
168161

0 commit comments

Comments
 (0)