Update CLI tool shim platforms to support ARM #819
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added win-arm64 and osx-arm64 - Removed win-x86 I don't think x86 is supported anymore, according to https://github.com/dotnet/sdk/blob/f578225fe1fdd93db9efac273562b3709db9e8e9/src/Cli/dotnet/ShellShim/ShellShimTemplateFinder.cs#L27
Contributor
Author
|
Caveats: I'm not entirely sure how to test this. I don't have an osx-arm64 machine to test, and my win-arm64 machine works just fine with the win-x64 package so it's hard to validate a difference. Also, I ran into #728 again while making this change because the runtime packages for these platforms aren't in the libman feed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think x86 is supported anymore, according to https://github.com/dotnet/sdk/blob/f578225fe1fdd93db9efac273562b3709db9e8e9/src/Cli/dotnet/ShellShim/ShellShimTemplateFinder.cs#L27
Resolves #708