Review API of new satellite rotations module #907
Description
Ensure that the current API of the satellite rotations module introduced in PR #905 is the most useful formulation for intrinsic alignment modeling, and also synthetic satellite/subhalo additions/transfer.
In particular, there should be consistency enforced between these functions and mock_observables.velocity_decomposition and catalog_analysis_helpers.relative_positions_and_velocities, since there is redundancy in those implementations.