Skip to content

Refactor JsEngine initialization into helper modules #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Refactor JsEngine initialization into helper modules #208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7805a48
Refactor JsEngine initialization into helper modules
rogeralsing Nov 22, 2025
0bcd150
Fix missing Symbols import in initialization helpers
rogeralsing Nov 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
125 changes: 125 additions & 0 deletions src/Asynkron.JsEngine/JsEngine.Initialization.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,125 @@
using Asynkron.JsEngine.Ast;
using Asynkron.JsEngine.JsTypes;
using Asynkron.JsEngine.Runtime;

namespace Asynkron.JsEngine;

public sealed partial class JsEngine
{
private void InitializeCoreGlobals()
{
// Bind the global object aliases and standard constructors used across libraries.
SetGlobal("globalThis", _globalObject);
SetGlobal("global", _globalObject);

SetGlobal("console", StandardLibrary.CreateConsoleObject());
SetGlobal("Math", StandardLibrary.CreateMathObject());
SetGlobal("Object", StandardLibrary.CreateObjectConstructor(_realm));
SetGlobal("Function", StandardLibrary.CreateFunctionConstructor(_realm));
SetGlobal("Number", StandardLibrary.CreateNumberConstructor(_realm));
var bigIntFunction = StandardLibrary.CreateBigIntFunction(_realm);
SetGlobal("BigInt", bigIntFunction);
SetGlobal("Boolean", StandardLibrary.CreateBooleanConstructor(_realm));
SetGlobal("String", StandardLibrary.CreateStringConstructor(_realm));
var arrayConstructor = StandardLibrary.CreateArrayConstructor(_realm);
SetGlobal("Array", arrayConstructor);
if (arrayConstructor is HostFunction arrayHost)
{
arrayHost.RealmState = _realm;
}
_globalObject.DefineProperty("Array", new PropertyDescriptor
{
Value = arrayConstructor,
Writable = true,
Enumerable = false,
Configurable = true
});
_globalObject.DefineProperty("BigInt", new PropertyDescriptor
{
Value = bigIntFunction,
Writable = true,
Enumerable = false,
Configurable = true
});

// Common global constants and parsing helpers.
SetGlobal("Infinity", double.PositiveInfinity);
SetGlobal("NaN", double.NaN);
SetGlobal("undefined", Symbols.Undefined);

SetGlobal("parseInt", StandardLibrary.CreateParseIntFunction());
SetGlobal("parseFloat", StandardLibrary.CreateParseFloatFunction());
SetGlobal("isNaN", StandardLibrary.CreateIsNaNFunction());
SetGlobal("isFinite", StandardLibrary.CreateIsFiniteFunction());

// Date constructor with static helpers attached to the callable function.
var dateConstructor = StandardLibrary.CreateDateConstructor(_realm);
var dateObj = StandardLibrary.CreateDateObject();

if (dateConstructor is HostFunction hf)
{
foreach (var prop in dateObj)
{
hf.SetProperty(prop.Key, prop.Value);
}
}

SetGlobal("Date", dateConstructor);
SetGlobal("JSON", StandardLibrary.CreateJsonObject());
SetGlobal("RegExp", StandardLibrary.CreateRegExpConstructor());
SetGlobal("Promise", StandardLibrary.CreatePromiseConstructor(this));
SetGlobal("Symbol", StandardLibrary.CreateSymbolConstructor());
SetGlobal("Map", StandardLibrary.CreateMapConstructor());
SetGlobal("Set", StandardLibrary.CreateSetConstructor());
SetGlobal("WeakMap", StandardLibrary.CreateWeakMapConstructor());
SetGlobal("Proxy", StandardLibrary.CreateProxyConstructor(_realm));
SetGlobal("WeakSet", StandardLibrary.CreateWeakSetConstructor());
SetGlobal("localStorage", StandardLibrary.CreateLocalStorageObject());
SetGlobal("Reflect", StandardLibrary.CreateReflectObject());

// Register eval as an environment-aware callable.
SetGlobal("eval", new EvalHostFunction(this));
}

private void InitializeTypedArrays()
{
SetGlobal("ArrayBuffer", StandardLibrary.CreateArrayBufferConstructor());
SetGlobal("DataView", StandardLibrary.CreateDataViewConstructor());
SetGlobal("Int8Array", StandardLibrary.CreateInt8ArrayConstructor());
SetGlobal("Uint8Array", StandardLibrary.CreateUint8ArrayConstructor());
SetGlobal("Uint8ClampedArray", StandardLibrary.CreateUint8ClampedArrayConstructor());
SetGlobal("Int16Array", StandardLibrary.CreateInt16ArrayConstructor());
SetGlobal("Uint16Array", StandardLibrary.CreateUint16ArrayConstructor());
SetGlobal("Int32Array", StandardLibrary.CreateInt32ArrayConstructor());
SetGlobal("Uint32Array", StandardLibrary.CreateUint32ArrayConstructor());
SetGlobal("Float32Array", StandardLibrary.CreateFloat32ArrayConstructor());
SetGlobal("Float64Array", StandardLibrary.CreateFloat64ArrayConstructor());
SetGlobal("BigInt64Array", StandardLibrary.CreateBigInt64ArrayConstructor());
SetGlobal("BigUint64Array", StandardLibrary.CreateBigUint64ArrayConstructor());
}

private void InitializeErrorConstructors()
{
SetGlobal("Error", StandardLibrary.CreateErrorConstructor(_realm, "Error"));
SetGlobal("TypeError", StandardLibrary.CreateErrorConstructor(_realm, "TypeError"));
SetGlobal("RangeError", StandardLibrary.CreateErrorConstructor(_realm, "RangeError"));
SetGlobal("ReferenceError", StandardLibrary.CreateErrorConstructor(_realm, "ReferenceError"));
SetGlobal("SyntaxError", StandardLibrary.CreateErrorConstructor(_realm, "SyntaxError"));
}

private void InitializeAsyncIterationHelpers()
{
SetGlobal("__getAsyncIterator", StandardLibrary.CreateGetAsyncIteratorHelper(this));
SetGlobal("__iteratorNext", StandardLibrary.CreateIteratorNextHelper(this));
SetGlobal("__awaitHelper", StandardLibrary.CreateAwaitHelper(this));
}

private void InitializeTimersAndImports()
{
SetGlobalFunction("setTimeout", SetTimeout);
SetGlobalFunction("setInterval", SetInterval);
SetGlobalFunction("clearTimeout", ClearTimer);
SetGlobalFunction("clearInterval", ClearTimer);
SetGlobalFunction("import", DynamicImport);
}
}
142 changes: 6 additions & 136 deletions src/Asynkron.JsEngine/JsEngine.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
/// <summary>
/// High level façade that turns JavaScript source into S-expressions and evaluates them.
/// </summary>
public sealed class JsEngine : IAsyncDisposable
public sealed partial class JsEngine : IAsyncDisposable
{
private readonly TaskCompletionSource _doneTcs = new();
private readonly JsEnvironment _global = new(isFunctionScope: true);
Expand All @@ -30,7 +30,7 @@
private readonly HashSet<Task> _activeTimerTasks = [];
private int _nextTimerId = 1;
private int _pendingTaskCount; // Track pending tasks in the event queue
private bool _asyncIteratorTracingEnabled;

Check warning on line 33 in src/Asynkron.JsEngine/JsEngine.cs

View workflow job for this annotation

GitHub Actions / build-and-test 

Field 'JsEngine._asyncIteratorTracingEnabled' is never assigned to, and will always have its default value false

// Module registry: maps module paths to their exported values
private readonly Dictionary<string, JsObject> _moduleRegistry = new();
Expand All @@ -56,143 +56,13 @@
{
var previousRealm = StandardLibrary.CurrentRealm;
StandardLibrary.BindRealm(_realm);
// Bind the global `this` value to a dedicated JS object so that
// top-level `this` behaves like the global object (e.g. for UMD
// wrappers such as babel-standalone).
_global.Define(Symbols.This, _globalObject);

// Expose common aliases for the global object that many libraries
// expect to exist (Node-style `global`, standard `globalThis`).
SetGlobal("globalThis", _globalObject);
SetGlobal("global", _globalObject);

// Register standard library objects
SetGlobal("console", StandardLibrary.CreateConsoleObject());
SetGlobal("Math", StandardLibrary.CreateMathObject());
SetGlobal("Object", StandardLibrary.CreateObjectConstructor(_realm));
SetGlobal("Function", StandardLibrary.CreateFunctionConstructor(_realm));
SetGlobal("Number", StandardLibrary.CreateNumberConstructor(_realm));
var bigIntFunction = StandardLibrary.CreateBigIntFunction(_realm);
SetGlobal("BigInt", bigIntFunction);
SetGlobal("Boolean", StandardLibrary.CreateBooleanConstructor(_realm));
SetGlobal("String", StandardLibrary.CreateStringConstructor(_realm));
var arrayConstructor = StandardLibrary.CreateArrayConstructor(_realm);
SetGlobal("Array", arrayConstructor);
if (arrayConstructor is HostFunction arrayHost)
{
arrayHost.RealmState = _realm;
}
_globalObject.DefineProperty("Array", new PropertyDescriptor
{
Value = arrayConstructor,
Writable = true,
Enumerable = false,
Configurable = true
});
_globalObject.DefineProperty("BigInt", new PropertyDescriptor
{
Value = bigIntFunction,
Writable = true,
Enumerable = false,
Configurable = true
});

// Register global constants
SetGlobal("Infinity", double.PositiveInfinity);
SetGlobal("NaN", double.NaN);
SetGlobal("undefined", Symbols.Undefined);

// Register global functions
SetGlobal("parseInt", StandardLibrary.CreateParseIntFunction());
SetGlobal("parseFloat", StandardLibrary.CreateParseFloatFunction());
SetGlobal("isNaN", StandardLibrary.CreateIsNaNFunction());
SetGlobal("isFinite", StandardLibrary.CreateIsFiniteFunction());

// Register Date constructor as a callable object with static methods
var dateConstructor = StandardLibrary.CreateDateConstructor(_realm);
var dateObj = StandardLibrary.CreateDateObject();

// Add static methods to constructor
if (dateConstructor is HostFunction hf)
{
foreach (var prop in dateObj)
{
hf.SetProperty(prop.Key, prop.Value);
}
}

SetGlobal("Date", dateConstructor);
SetGlobal("JSON", StandardLibrary.CreateJsonObject());

// Register RegExp constructor
SetGlobal("RegExp", StandardLibrary.CreateRegExpConstructor());

// Register Promise constructor
SetGlobal("Promise", StandardLibrary.CreatePromiseConstructor(this));

// Register Symbol constructor
SetGlobal("Symbol", StandardLibrary.CreateSymbolConstructor());

// Register Map constructor
SetGlobal("Map", StandardLibrary.CreateMapConstructor());

// Register Set constructor
SetGlobal("Set", StandardLibrary.CreateSetConstructor());

// Register WeakMap constructor
SetGlobal("WeakMap", StandardLibrary.CreateWeakMapConstructor());

// Minimal Proxy constructor (used by Array.isArray proxy tests)
SetGlobal("Proxy", StandardLibrary.CreateProxyConstructor(_realm));

// Register WeakSet constructor
SetGlobal("WeakSet", StandardLibrary.CreateWeakSetConstructor());

// Minimal browser-like storage object used by debug/babel-standalone.
SetGlobal("localStorage", StandardLibrary.CreateLocalStorageObject());

// Reflect object
SetGlobal("Reflect", StandardLibrary.CreateReflectObject());

// Register ArrayBuffer and TypedArray constructors
SetGlobal("ArrayBuffer", StandardLibrary.CreateArrayBufferConstructor());
SetGlobal("DataView", StandardLibrary.CreateDataViewConstructor());
SetGlobal("Int8Array", StandardLibrary.CreateInt8ArrayConstructor());
SetGlobal("Uint8Array", StandardLibrary.CreateUint8ArrayConstructor());
SetGlobal("Uint8ClampedArray", StandardLibrary.CreateUint8ClampedArrayConstructor());
SetGlobal("Int16Array", StandardLibrary.CreateInt16ArrayConstructor());
SetGlobal("Uint16Array", StandardLibrary.CreateUint16ArrayConstructor());
SetGlobal("Int32Array", StandardLibrary.CreateInt32ArrayConstructor());
SetGlobal("Uint32Array", StandardLibrary.CreateUint32ArrayConstructor());
SetGlobal("Float32Array", StandardLibrary.CreateFloat32ArrayConstructor());
SetGlobal("Float64Array", StandardLibrary.CreateFloat64ArrayConstructor());
SetGlobal("BigInt64Array", StandardLibrary.CreateBigInt64ArrayConstructor());
SetGlobal("BigUint64Array", StandardLibrary.CreateBigUint64ArrayConstructor());

// Register Error constructors
SetGlobal("Error", StandardLibrary.CreateErrorConstructor(_realm, "Error"));
SetGlobal("TypeError", StandardLibrary.CreateErrorConstructor(_realm, "TypeError"));
SetGlobal("RangeError", StandardLibrary.CreateErrorConstructor(_realm, "RangeError"));
SetGlobal("ReferenceError", StandardLibrary.CreateErrorConstructor(_realm, "ReferenceError"));
SetGlobal("SyntaxError", StandardLibrary.CreateErrorConstructor(_realm, "SyntaxError"));

// Register eval function as an environment-aware callable
// This allows eval to execute code in the caller's scope without blocking the event loop
SetGlobal("eval", new EvalHostFunction(this));

// Register internal helpers for async iteration
SetGlobal("__getAsyncIterator", StandardLibrary.CreateGetAsyncIteratorHelper(this));
SetGlobal("__iteratorNext", StandardLibrary.CreateIteratorNextHelper(this));
SetGlobal("__awaitHelper", StandardLibrary.CreateAwaitHelper(this));

// Register timer functions
SetGlobalFunction("setTimeout", SetTimeout);
SetGlobalFunction("setInterval", SetInterval);
SetGlobalFunction("clearTimeout", ClearTimer);
SetGlobalFunction("clearInterval", ClearTimer);

// Register dynamic import function
SetGlobalFunction("import", DynamicImport);
InitializeCoreGlobals();
InitializeTypedArrays();
InitializeErrorConstructors();
InitializeAsyncIterationHelpers();
InitializeTimersAndImports();

// Register debug function as a debug-aware host function
_global.Define(Symbol.Intern("__debug"), new DebugAwareHostFunction(CaptureDebugMessage));
Expand Down
Loading