From bf65da15ad41d3e7a554b3a5bbb7d946760053e9 Mon Sep 17 00:00:00 2001
From: Max Gagnon <82063767+maxwellgagnon@users.noreply.github.com>
Date: Mon, 22 Jan 2024 18:02:13 -0600
Subject: [PATCH] Modify shared.Field table definition to handle LBM scans

Currently, shared.Field() is created with 25 fields. This is not sufficient to handle the expected range of fields per scan for LBM scans, e.g. 5 fields per 30 depths = 150 fields total.

Additionally, the datatype used in this table should be changed from tinyint to smallint, as tinyint only has a range of (-128 to 127). smallint has a more-than-sufficient range of (-32,768 to 32,767).

This table will likely not be re-created prior to the development of a/the pipeline. I'm making this PR to remind those in the future to consider this when making design choices for that new pipeline. Feel free to leave this PR un-approved until that time.
---
 python/pipeline/shared.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/python/pipeline/shared.py b/python/pipeline/shared.py
index e90f4282..8b4945f1 100644
--- a/python/pipeline/shared.py
+++ b/python/pipeline/shared.py
@@ -10,9 +10,9 @@
 @schema
 class Field(dj.Lookup):
     definition = """ # fields in mesoscope scans
-    field       : tinyint
+    field       : smallint
     """
-    contents = [[i] for i in range(1, 25)]
+    contents = [[i] for i in range(1, 150)]
 
 @schema
 class Channel(dj.Lookup):