Merge pull request #253 from atom/mb-handle-destruction-during-save

On destroy, don't clear native buffer until all saves are done

Author: Max Brunsfeld

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "text-buffer",
-  "version": "13.1.14",
+  "version": "13.1.15-0",
   "description": "A container for large mutable strings with annotated regions",
   "main": "./lib/text-buffer",
   "scripts": {

package.json

@@ -238,6 +238,18 @@ describe('TextBuffer IO', () => {
       })
     })
 
+    describe('when the buffer is destroyed before the save completes', () => {
+      it('saves the current contents of the buffer to the path', (done) => {
+        buffer.setText('hello\n')
+        buffer.save().then(() => {
+          expect(buffer.getText()).toBe('')
+          expect(fs.readFileSync(filePath, 'utf8')).toBe('hello\n')
+          done()
+        })
+        buffer.destroy()
+      })
+    })
+
     describe('when a conflict is created', () => {
       beforeEach((done) => {
         buffer.setText('a')

spec/text-buffer-io-spec.js

@@ -1724,7 +1724,14 @@ class TextBuffer
       @fileSubscriptions?.dispose()
       for id, markerLayer of @markerLayers
         markerLayer.destroy()
-      @buffer.reset('')
+      if @outstandingSaveCount is 0
+        @buffer.reset('')
+      else
+        subscription = @onDidSave =>
+          if @outstandingSaveCount is 0
+            @buffer.reset('')
+            subscription.dispose()
+
       @cachedText = null
       @history.clear()