Fix(stream): Correct newline handling in streaming functions

Refactored `ollama_generate_stream` to use a more robust method for
handling streaming responses, similar to `ollama_chat_stream`.

This change fixes a bug where newlines were not being handled correctly
in the streaming output. The new implementation uses `jq -r` to extract
and unescape the response content, and `printf '%s'` to print the raw
string without interpreting escape sequences. This ensures that newlines
and other special characters in the model's response are rendered
correctly.

The `ollama_chat_stream` function was also reviewed and found to be
already using the correct approach.

Author: google-labs-jules[bot]

ollama_bash_lib.sh

@@ -756,52 +756,25 @@ ollama_generate_stream() {
     _debug "ollama_generate_stream: model='$model'  prompt='${prompt:0:40}'"
 
     OBL_STREAM=1
-
-    local is_thinking=false
-    local is_responding=false
-
-    ollama_generate_json -m "$model" -p "$prompt" |
-    while IFS= read -r line; do
-
-        #_debug "ollama_generate_stream: line: [${line:0:1000}]"
-
-        thinking="$(jq '.thinking // empty' <<<"$line")"
-        thinking=${thinking#\"} # strip first "
-        thinking=${thinking%\"} # strip last "
-        if [[ -n "$thinking" ]]; then
-            if [[ "$is_thinking" == 'false' ]]; then
-                # first thinking input received
-                is_thinking=true
-                printf '\n#### %b' "$thinking"
-            else 
-                # subsequent thinking input received
-                printf '%b' "$thinking"
-            fi
-        fi
-        
-        response="$(jq '.response // empty' <<<"$line")"
-        response=${response#\"} # strip first "
-        response=${response%\"} # strip last "
-        if [[ -n "$response" ]]; then
-            if [[ "$is_responding" == 'false' ]]; then
-                # first response input received
-                is_responding=true
-                printf '\n\n%b' "$response"
-            else 
-                # subsequent response input received
-                printf '%b' "$response"
+    (
+        ollama_generate_json -m "$model" -p "$prompt" | while IFS= read -r line; do
+            if ! _is_valid_json "$line"; then continue; fi
+            if [[ "$OBL_THINKING" == 'on' ]]; then
+                printf '%s' "$(jq -r '.thinking // empty' <<<"$line")" >&2
             fi
-        fi
-    done
-    rc=$?    # exit status of the whole pipeline
-
+            read -r -d '' response < <(jq -r '.response // empty' <<<"$line")
+            printf '%s' "$response"
+        done
+        exit "${PIPESTATUS[0]}"
+    ) 2> >( _ollama_thinking_stream )
+    local error_code=$?
     OBL_STREAM=0
-
-    # Final newline (only on success)
-    (( rc == 0 )) && printf '\n'
-
-    _debug "ollama_generate_stream: exit=$rc"
-    return $rc
+    if [[ $error_code -ne 0 ]]; then
+        _error "ollama_generate_stream: ollama_generate_json failed with code $error_code"
+        return 1
+    fi
+    printf '\n'
+    return 0
 }
 
 # Messages Functions