Skip to content

Recover from errors more nicely. #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Recover from errors more nicely. #114

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions src/clojureEval.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,8 +163,14 @@ function evaluate(outputChannel: vscode.OutputChannel, showResults: boolean): vo
response = nreplClient.evaluateFile(text, editor.document.fileName, session.id);
}
response.then(respObjs => {
if (!!respObjs[0].ex)
return handleError(outputChannel, selection, showResults, respObjs[0].session);
if (!!respObjs[0].ex) {
vscode.window.showErrorMessage("Compilation Error")
for (let error of respObjs.map((r) => r.err).filter((e) => e)) {
outputChannel.append(error);
}
return
}


return handleSuccess(outputChannel, showResults, respObjs);
})
Expand All @@ -179,6 +185,11 @@ function handleError(outputChannel: vscode.OutputChannel, selection: vscode.Sele
.then(stacktraceObjs => {
const stacktraceObj = stacktraceObjs[0];

if (stacktraceObj.status && stacktraceObj.status.indexOf("unknown-op") != -1) {
outputChannel.appendLine("Failed to run get a stacktrace: the cider.nrepl.middleware.stacktrace middleware in not loaded.");
return;
}

let errLine = stacktraceObj.line !== undefined ? stacktraceObj.line - 1 : 0;
let errChar = stacktraceObj.column !== undefined ? stacktraceObj.column - 1 : 0;

Expand Down