Add minor improvements

Suggested by GitHub Copilot on PR review.

Author: onethumb

src/crc32/fusion/aarch64/mod.rs

@@ -28,7 +28,7 @@ use iso_hdlc::crc_pmull_sha3::crc32_iso_hdlc_eor3_v9s3x2e_s3;
 pub fn crc32_iscsi(crc: u32, data: &[u8]) -> u32 {
     let data_len = data.len();
 
-    // there's some variance among different aarch64 CPUs (Applie Silicon, AWS Graviton, etc), but
+    // there's some variance among different aarch64 CPUs (Apple Silicon, AWS Graviton, etc.), but
     // 127 bytes is the "small" threshold where this is generally faster
     if data_len < 128 {
         return unsafe { crc32_iscsi_small_fast(crc, data) };
@@ -50,7 +50,7 @@ pub fn crc32_iscsi(crc: u32, data: &[u8]) -> u32 {
 pub fn crc32_iso_hdlc(crc: u32, data: &[u8]) -> u32 {
     let data_len = data.len();
 
-    // there's some variance among different aarch64 CPUs (Applie Silicon, AWS Graviton, etc), but
+    // there's some variance among different aarch64 CPUs (Apple Silicon, AWS Graviton, etc.), but
     // 127 bytes is the "small" threshold where this is generally faster
     if data_len < 128 {
         return unsafe { crc32_iso_hdlc_small_fast(crc, data) };
@@ -68,7 +68,6 @@ pub fn crc32_iso_hdlc(crc: u32, data: &[u8]) -> u32 {
     }
 }
 
-/// Safe wrapper for CRC-32/ISCSI calculation with AES + SHA3 support
 #[inline]
 #[target_feature(enable = "crc,aes,sha3")]
 unsafe fn crc32_iscsi_aes_sha3(crc: u32, data: &[u8], data_len: usize) -> u32 {
@@ -90,7 +89,6 @@ unsafe fn crc32_iscsi_aes(crc: u32, data: &[u8], data_len: usize) -> u32 {
     unsafe { crc32_iscsi_v12e_v1(crc, data.as_ptr(), data_len) }
 }
 
-/// Safe wrapper for CRC32 ISO-HDLC calculation
 #[inline]
 #[target_feature(enable = "crc,aes,sha3")]
 unsafe fn crc32_iso_hdlc_aes_sha3(crc: u32, data: &[u8], data_len: usize) -> u32 {
@@ -148,7 +146,7 @@ unsafe fn clmul_hi_and_xor(a: uint64x2_t, b: uint64x2_t, c: uint64x2_t) -> uint6
     veorq_u64(clmul_hi(a, b), c)
 }
 
-/// CRC-32/ISCSI calculation for small buffers (<= 96 bytes) using unrolled native CRC instructions
+/// CRC-32/ISCSI calculation for small buffers (< 128 bytes) using unrolled native CRC instructions
 #[inline]
 #[target_feature(enable = "crc")]
 pub unsafe fn crc32_iscsi_small_fast(mut crc: u32, data: &[u8]) -> u32 {
@@ -185,7 +183,7 @@ pub unsafe fn crc32_iscsi_small_fast(mut crc: u32, data: &[u8]) -> u32 {
     crc
 }
 
-/// CRC-32/ISO-HDLC calculation for small buffers (<= 96 bytes) using unrolled native CRC instructions
+/// CRC-32/ISO-HDLC calculation for small buffers (< 128 bytes) using unrolled native CRC instructions
 #[inline]
 #[target_feature(enable = "crc")]
 pub unsafe fn crc32_iso_hdlc_small_fast(mut crc: u32, data: &[u8]) -> u32 {

src/lib.rs

@@ -1000,6 +1000,7 @@ pub fn crc32_iscsi(data: &[u8]) -> u32 {
 /// let checksum = crc32_iso_hdlc(b"123456789");
 /// assert_eq!(checksum, 0xcbf43926);
 /// ```
+#[inline(always)]
 pub fn crc32_iso_hdlc(data: &[u8]) -> u32 {
     crc32_iso_hdlc_calculator(CRC32_ISO_HDLC.init, data, &CRC32_ISO_HDLC) as u32
         ^ CRC32_ISO_HDLC.xorout as u32
@@ -1019,6 +1020,7 @@ pub fn crc32_iso_hdlc(data: &[u8]) -> u32 {
 /// let checksum = crc64_nvme(b"123456789");
 /// assert_eq!(checksum, 0xae8b14860a799888);
 /// ```
+#[inline(always)]
 pub fn crc64_nvme(data: &[u8]) -> u64 {
     Calculator::calculate(CRC64_NVME.init, data, &CRC64_NVME) ^ CRC64_NVME.xorout
 }