diff --git a/apis/v1alpha1/ack-generate-metadata.yaml b/apis/v1alpha1/ack-generate-metadata.yaml index a46cbd5..3f317e8 100755 --- a/apis/v1alpha1/ack-generate-metadata.yaml +++ b/apis/v1alpha1/ack-generate-metadata.yaml @@ -1,8 +1,8 @@ ack_generate_info: - build_date: "2025-08-15T00:08:10Z" - build_hash: b6df33f8c7f55b234555c0b578b8de43c74771a8 - go_version: go1.24.6 - version: v0.51.0 + build_date: "2025-09-19T21:33:27Z" + build_hash: 6b4211163dcc34776b01da9a18217bac0f4103fd + go_version: go1.24.5 + version: v0.52.0-dirty api_directory_checksum: f27db0327167670395f1f06471960f393d57f6b8 api_version: v1alpha1 aws_sdk_go_version: v1.32.6 diff --git a/pkg/resource/collection/resource.go b/pkg/resource/collection/resource.go index 5dbc60c..5bf9b64 100644 --- a/pkg/resource/collection/resource.go +++ b/pkg/resource/collection/resource.go @@ -97,7 +97,7 @@ func (r *resource) SetIdentifiers(identifier *ackv1alpha1.AWSIdentifiers) error // PopulateResourceFromAnnotation populates the fields passed from adoption annotation func (r *resource) PopulateResourceFromAnnotation(fields map[string]string) error { - tmp, ok := fields["arn"] + resourceARN, ok := fields["arn"] if !ok { return ackerrors.NewTerminalError(fmt.Errorf("required field missing: arn")) } @@ -105,7 +105,7 @@ func (r *resource) PopulateResourceFromAnnotation(fields map[string]string) erro if r.ko.Status.ACKResourceMetadata == nil { r.ko.Status.ACKResourceMetadata = &ackv1alpha1.ResourceMetadata{} } - arn := ackv1alpha1.AWSResourceName(tmp) + arn := ackv1alpha1.AWSResourceName(resourceARN) r.ko.Status.ACKResourceMetadata.ARN = &arn return nil diff --git a/pkg/resource/security_policy/resource.go b/pkg/resource/security_policy/resource.go index 92200a1..ab0b65e 100644 --- a/pkg/resource/security_policy/resource.go +++ b/pkg/resource/security_policy/resource.go @@ -103,16 +103,16 @@ func (r *resource) SetIdentifiers(identifier *ackv1alpha1.AWSIdentifiers) error // PopulateResourceFromAnnotation populates the fields passed from adoption annotation func (r *resource) PopulateResourceFromAnnotation(fields map[string]string) error { - tmp, ok := fields["name"] + f0, ok := fields["name"] if !ok { return ackerrors.NewTerminalError(fmt.Errorf("required field missing: name")) } - r.ko.Spec.Name = &tmp - - f1, f1ok := fields["type_"] - if f1ok { - r.ko.Spec.Type = aws.String(f1) + r.ko.Spec.Name = &f0 + f1, ok := fields["type_"] + if !ok { + return ackerrors.NewTerminalError(fmt.Errorf("required field missing: type_")) } + r.ko.Spec.Type = &f1 return nil }