Changes from feedback

Author: hjgraca

libraries/src/AWS.Lambda.Powertools.Idempotency/Idempotency.cs

@@ -90,22 +90,15 @@ public static void Configure(Action<IdempotencyBuilder> configurationAction)
     /// </summary>
     public class IdempotencyBuilder
     {
-        /// <summary>
-        /// Holds Idempotency options
-        /// </summary>
-        private IdempotencyOptions _options;
-        /// <summary>
-        /// Persistence Store
-        /// </summary>
-        private BasePersistenceStore _store;
         /// <summary>
         /// Exposes Idempotency options
         /// </summary>
-        internal IdempotencyOptions Options => _options;
+        internal IdempotencyOptions Options { get; private set; }
+
         /// <summary>
         /// Exposes Persistence Store
         /// </summary>
-        internal BasePersistenceStore Store => _store;
+        internal BasePersistenceStore Store { get; private set; }
 
         /// <summary>
         /// Set the persistence layer to use for storing the request and response
@@ -114,7 +107,7 @@ public class IdempotencyBuilder
         /// <returns>IdempotencyBuilder</returns>
         public IdempotencyBuilder WithPersistenceStore(BasePersistenceStore persistenceStore)
         {
-            _store = persistenceStore;
+            Store = persistenceStore;
             return this;
         }
 
@@ -128,7 +121,7 @@ public IdempotencyBuilder UseDynamoDb(Action<DynamoDBPersistenceStoreBuilder> bu
             var builder =
                 new DynamoDBPersistenceStoreBuilder();
             builderAction(builder);
-            _store = builder.Build();
+            Store = builder.Build();
             return this;
         }
 
@@ -141,7 +134,7 @@ public IdempotencyBuilder UseDynamoDb(string tableName)
         {
             var builder =
                 new DynamoDBPersistenceStoreBuilder();
-            _store = builder.WithTableName(tableName).Build();
+            Store = builder.WithTableName(tableName).Build();
             return this;
         }
 
@@ -154,7 +147,7 @@ public IdempotencyBuilder WithOptions(Action<IdempotencyOptionsBuilder> builderA
         {
             var builder = new IdempotencyOptionsBuilder();
             builderAction(builder);
-            _options = builder.Build();
+            Options = builder.Build();
             return this;
         }
 
@@ -165,7 +158,7 @@ public IdempotencyBuilder WithOptions(Action<IdempotencyOptionsBuilder> builderA
         /// <returns>IdempotencyBuilder</returns>
         public IdempotencyBuilder WithOptions(IdempotencyOptions options)
         {
-            _options = options;
+            Options = options;
             return this;
         }
     }

libraries/src/AWS.Lambda.Powertools.Idempotency/IdempotentAttribute.cs

@@ -14,6 +14,7 @@
  */
 
 using System;
+using System.Linq;
 using System.Text.Json;
 using System.Threading.Tasks;
 using AspectInjector.Broker;
@@ -73,7 +74,8 @@ protected internal sealed override T WrapSync<T>(Func<object[], T> target, objec
         {
             return base.WrapSync(target, args, eventArgs);
         }
-        var payload = JsonDocument.Parse(JsonSerializer.Serialize(args[0]));
+        
+        var payload = args is not null && args.Any() ? JsonDocument.Parse(JsonSerializer.Serialize(args[0])) : null;
         if (payload == null)
         {
             throw new IdempotencyConfigurationException("Unable to get payload from the method. Ensure there is at least one parameter or that you use @IdempotencyKey");
@@ -105,7 +107,8 @@ protected internal sealed override async Task<T> WrapAsync<T>(
         {
             return await base.WrapAsync(target, args, eventArgs);
         }
-        var payload = JsonDocument.Parse(JsonSerializer.Serialize(args[0]));
+        
+        var payload = args is not null && args.Any() ? JsonDocument.Parse(JsonSerializer.Serialize(args[0])) : null;
         if (payload == null)
         {
             throw new IdempotencyConfigurationException("Unable to get payload from the method. Ensure there is at least one parameter or that you use @IdempotencyKey");

libraries/src/AWS.Lambda.Powertools.Idempotency/Persistence/BasePersistenceStore.cs

@@ -29,7 +29,7 @@ namespace AWS.Lambda.Powertools.Idempotency.Persistence;
 /// <summary>
 /// Persistence layer that will store the idempotency result.
 /// Base implementation. See <see cref="DynamoDBPersistenceStore"/> for an implementation (default one)
-/// Extend this class to use your own implementation (DocumentDB, Elasticache, ...)
+/// Extend this class to use your own implementation (DocumentDB, ElastiCache, ...)
 /// </summary>
 public abstract class BasePersistenceStore : IPersistenceStore
 {

libraries/src/AWS.Lambda.Powertools.Idempotency/Persistence/DataRecord.cs

@@ -75,24 +75,12 @@ public bool IsExpired(DateTimeOffset now)
     {
         return ExpiryTimestamp != 0 && now.ToUnixTimeSeconds() > ExpiryTimestamp;
     }
-
 
     /// <summary>
     /// Represents the <see cref="DataRecordStatus"/> Status
     /// </summary>
-    public DataRecordStatus Status
-    {
-        get
-        {
-            var now = DateTimeOffset.UtcNow;
-            if (IsExpired(now))
-            {
-                return DataRecordStatus.EXPIRED;
-            }
-
-            return Enum.Parse<DataRecordStatus>(_status);
-        }
-    }
+    public DataRecordStatus Status => 
+        IsExpired(DateTimeOffset.UtcNow) ? DataRecordStatus.EXPIRED : Enum.Parse<DataRecordStatus>(_status);
 
     /// <summary>
     /// Determines whether the specified DataRecord is equal to the current DataRecord 

libraries/tests/AWS.Lambda.Powertools.Idempotency.Tests/Handlers/IdempotencyFunction.cs

@@ -35,7 +35,6 @@ public IdempotencyFunction(AmazonDynamoDBClient client)
             builder
                 .WithOptions(optionsBuilder =>
                     optionsBuilder
-                        //.WithUseLocalCache(true)
                         .WithEventKeyJmesPath("powertools_json(Body).address")
                         .WithExpiration(TimeSpan.FromSeconds(20)))
                 .UseDynamoDb(storeBuilder =>