adressing pr comments

Author: hjgraca

libraries/src/AWS.Lambda.Powertools.Idempotency/Persistence/BasePersistenceStore.cs

@@ -225,15 +225,13 @@ private DataRecord RetrieveFromCache(string idempotencyKey, DateTimeOffset now)
     {
         if (!_idempotencyOptions.UseLocalCache)
             return null;
-        
-        if (_cache.TryGet(idempotencyKey, out var record) && record!=null)
+
+        if (!_cache.TryGet(idempotencyKey, out var record) || record == null) return null;
+        if (!record.IsExpired(now)) 
         {
-            if (!record.IsExpired(now)) 
-            {
-                return record;
-            }
-            DeleteFromCache(idempotencyKey);
+            return record;
         }
+        DeleteFromCache(idempotencyKey);
         return null;
     }
 
@@ -262,7 +260,7 @@ private string GetHashedPayload(JsonDocument data)
         }
 
         var transformer = JsonTransformer.Parse(_idempotencyOptions.PayloadValidationJmesPath);
-        JsonDocument result = transformer.Transform(data.RootElement);
+        var result = transformer.Transform(data.RootElement);
         return GenerateHash(result.RootElement);
     }
 
@@ -289,7 +287,7 @@ private string GetHashedIdempotencyKey(JsonDocument data)
         if (eventKeyJmesPath != null) 
         {
             var transformer = JsonTransformer.Parse(eventKeyJmesPath);
-            JsonDocument result = transformer.Transform(node);
+            var result = transformer.Transform(node);
             node = result.RootElement;
         }
 

libraries/src/AWS.Lambda.Powertools.JMESPath/Expressions/BaseExpression.cs

@@ -1,5 +1,5 @@
 /*
-  * Copyright JsonCons.Net authors. All Rights Reserved.
+ * Copyright JsonCons.Net authors. All Rights Reserved.
  *
  * Licensed under the Apache License, Version 2.0 (the "License").
  * You may not use this file except in compliance with the License.

libraries/src/AWS.Lambda.Powertools.JMESPath/Expressions/CurrentNode.cs

@@ -1,5 +1,5 @@
 /*
-  * Copyright JsonCons.Net authors. All Rights Reserved.
+ * Copyright JsonCons.Net authors. All Rights Reserved.
  *
  * Licensed under the Apache License, Version 2.0 (the "License").
  * You may not use this file except in compliance with the License.

libraries/src/AWS.Lambda.Powertools.JMESPath/Expressions/Expression.cs

@@ -1,5 +1,5 @@
 /*
-  * Copyright JsonCons.Net authors. All Rights Reserved.
+ * Copyright JsonCons.Net authors. All Rights Reserved.
  *
  * Licensed under the Apache License, Version 2.0 (the "License").
  * You may not use this file except in compliance with the License.

libraries/src/AWS.Lambda.Powertools.JMESPath/Expressions/FilterExpression.cs

@@ -1,5 +1,5 @@
 /*
-  * Copyright JsonCons.Net authors. All Rights Reserved.
+ * Copyright JsonCons.Net authors. All Rights Reserved.
  *
  * Licensed under the Apache License, Version 2.0 (the "License").
  * You may not use this file except in compliance with the License.

libraries/src/AWS.Lambda.Powertools.JMESPath/Expressions/FlattenProjection.cs

@@ -1,5 +1,5 @@
 /*
-  * Copyright JsonCons.Net authors. All Rights Reserved.
+ * Copyright JsonCons.Net authors. All Rights Reserved.
  *
  * Licensed under the Apache License, Version 2.0 (the "License").
  * You may not use this file except in compliance with the License.

libraries/src/AWS.Lambda.Powertools.JMESPath/Expressions/FunctionExpression.cs

@@ -1,5 +1,5 @@
 /*
-  * Copyright JsonCons.Net authors. All Rights Reserved.
+ * Copyright JsonCons.Net authors. All Rights Reserved.
  *
  * Licensed under the Apache License, Version 2.0 (the "License").
  * You may not use this file except in compliance with the License.

libraries/src/AWS.Lambda.Powertools.JMESPath/Expressions/IExpression.cs

@@ -1,5 +1,5 @@
 /*
-  * Copyright JsonCons.Net authors. All Rights Reserved.
+ * Copyright JsonCons.Net authors. All Rights Reserved.
  *
  * Licensed under the Apache License, Version 2.0 (the "License").
  * You may not use this file except in compliance with the License.

libraries/src/AWS.Lambda.Powertools.JMESPath/Expressions/IdentifierSelector.cs

@@ -1,5 +1,5 @@
 /*
-  * Copyright JsonCons.Net authors. All Rights Reserved.
+ * Copyright JsonCons.Net authors. All Rights Reserved.
  *
  * Licensed under the Apache License, Version 2.0 (the "License").
  * You may not use this file except in compliance with the License.

libraries/src/AWS.Lambda.Powertools.JMESPath/Expressions/IndexSelector.cs

@@ -1,5 +1,5 @@
 /*
-  * Copyright JsonCons.Net authors. All Rights Reserved.
+ * Copyright JsonCons.Net authors. All Rights Reserved.
  *
  * Licensed under the Apache License, Version 2.0 (the "License").
  * You may not use this file except in compliance with the License.