diff --git a/src/cloud/pipelines/image_classification/evaluation.py b/src/cloud/pipelines/image_classification/evaluation.py index 5d44a5a..d43e2b4 100644 --- a/src/cloud/pipelines/image_classification/evaluation.py +++ b/src/cloud/pipelines/image_classification/evaluation.py @@ -63,7 +63,26 @@ model_path_extracted = './model/' with tarfile.open(model_path) as tar: - tar.extractall(path=model_path_extracted) + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(tar, path=model_path_extracted) # Get the files needed for loading, parse some strings symbol_file = glob(os.path.join(model_path_extracted, '*symbol.json'))[0]