Add typecasting to lowercaseCharacter function

Author: AniruddhaKanhere

.github/workflows/ci.yml

@@ -35,7 +35,7 @@ jobs:
           -G "Unix Makefiles" \
           -DCMAKE_BUILD_TYPE=Debug \
           -DUNITTEST=ON \
-          -DCMAKE_C_FLAGS='--coverage -Wall -Wextra -DNDEBUG -DLOGGING_LEVEL_DEBUG=1'
+          -DCMAKE_C_FLAGS='--coverage -Wall -Wextra -DNDEBUG'
           make -C build/ all
 
       - name: Test
@@ -47,9 +47,9 @@ jobs:
       - name: Run Coverage
         run: |
           make -C build/ coverage
-          declare -a EXCLUDE=("\*test\*" "\*CMakeCCompilerId\*" "\*mocks\*")
-          echo ${EXCLUDE[@]} | xargs lcov --rc lcov_branch_coverage=1 -r build/coverage.info -o build/coverage.info
-          lcov --rc lcov_branch_coverage=1 --list build/coverage.info
+          declare -a EXCLUDE=("\*test\*" "\*CMakeCCompilerId.c")
+          echo ${EXCLUDE[@]} | xargs lcov --rc  branch_coverage=1 --ignore-errors empty  --ignore-errors source -r build/coverage.info -o build/coverage.info
+          lcov --rc  branch_coverage=1 --ignore-errors empty --ignore-errors source --list build/coverage.info
 
       - name: Check Coverage
         uses: FreeRTOS/CI-CD-Github-Actions/coverage-cop@main

source/sigv4.c

@@ -1417,7 +1417,7 @@ static void generateCredentialScope( const SigV4Parameters_t * pSigV4Params,
 
         if( ( inputChar >= 'A' ) && ( inputChar <= 'Z' ) )
         {
-            outputChar = inputChar + offset;
+            outputChar = ( char ) ( ( ( int8_t ) inputChar ) + offset );
         }
         else
         {

test/unit-test/sigv4_config.h

@@ -36,9 +36,6 @@
 #ifndef SIGV4_CONFIG_H_
 #define SIGV4_CONFIG_H_
 
-
-#define LOGGING_LEVEL_DEBUG    1
-
 /* @[code_example_loggingmacros] */
 /************* Define Logging Macros using printf function ***********/
 

tools/cmock/coverage.cmake

@@ -14,9 +14,12 @@ execute_process( COMMAND lcov --directory ${CMAKE_BINARY_DIR}
                          --base-directory ${CMAKE_BINARY_DIR}
                          --initial
                          --capture
-                         --rc lcov_branch_coverage=1
+                         --rc branch_coverage=1
+                         --ignore-errors empty
+                         --ignore-errors source
                          --rc genhtml_branch_coverage=1
                          --output-file=${CMAKE_BINARY_DIR}/base_coverage.info
+                         --quiet
         )
 file(GLOB files "${CMAKE_BINARY_DIR}/bin/tests/*")
 
@@ -35,6 +38,7 @@ foreach(testname ${files})
     file(APPEND ${REPORT_FILE} "${CONTENTS}")
 endforeach()
 
+
 # generate Junit style xml output
 execute_process(COMMAND ruby
     ${CMOCK_DIR}/vendor/unity/auto/parse_output.rb
@@ -45,11 +49,14 @@ execute_process(COMMAND ruby
 # capture data after running the tests
 execute_process(
             COMMAND lcov --capture
-                         --rc lcov_branch_coverage=1
+                         --rc branch_coverage=1
+                         --ignore-errors empty
+                         --ignore-errors source
                          --rc genhtml_branch_coverage=1
                          --base-directory ${CMAKE_BINARY_DIR}
                          --directory ${CMAKE_BINARY_DIR}
                          --output-file ${CMAKE_BINARY_DIR}/second_coverage.info
+                         --quiet
         )
 
 # combile baseline results (zeros) with the one after running the tests
@@ -60,11 +67,17 @@ execute_process(
                          --add-tracefile ${CMAKE_BINARY_DIR}/second_coverage.info
                          --output-file ${CMAKE_BINARY_DIR}/coverage.info
                          --no-external
-                         --rc lcov_branch_coverage=1
+                         --rc branch_coverage=1
+                         --ignore-errors empty
+                         --ignore-errors source
+                         --quiet
         )
 execute_process(
-            COMMAND genhtml --rc lcov_branch_coverage=1
+            COMMAND genhtml --rc branch_coverage=1
+                            --ignore-errors empty
+                            --ignore-errors source
                             --branch-coverage
                             --output-directory ${CMAKE_BINARY_DIR}/coverage
                                 ${CMAKE_BINARY_DIR}/coverage.info
+                            --quiet
         )