Skip to content

Conversation

@aemous
Copy link
Contributor

@aemous aemous commented Dec 8, 2025

Description of changes:

  • Reduced false positives for URL params upgrade warning.
  • Improved spacing around upgrade warnings by prefixing all upgrade warnings with newline character \n.
  • Added parsed_globals globals args to the load-cli-arg event.
  • Updated tests to support the changes above.

Description of tests:

  • Manually tested the changes with a command that supports URL params.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.32%. Comparing base (5a98bdf) to head (cab3033).
⚠️ Report is 1 commits behind head on debug-migration.

Additional details and impacted files
@@               Coverage Diff                @@
##           debug-migration    #9899   +/-   ##
================================================
  Coverage            93.32%   93.32%           
================================================
  Files                  209      209           
  Lines                16909    16911    +2     
================================================
+ Hits                 15780    15783    +3     
+ Misses                1129     1128    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@aemous aemous marked this pull request as ready for review December 8, 2025 17:49
@aemous aemous requested a review from a team December 8, 2025 17:49
if v2_debug and fail_on_empty_changeset:
uni_print(
'AWS CLI v2 UPGRADE WARNING: In AWS CLI v2, '
'\nAWS CLI v2 UPGRADE WARNING: In AWS CLI v2, '
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might not matter at this point, but could have been nice to wrap all of these in a print_migration_debug_message

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, one caveat is, code under /customizations should use uni_print, and all other code should use print. May need a boolean arg to choose between either. Does this approach sound good with you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants