Update the action for golangci-lint (#303)

* update the version of golangci-lint, and switch to using the github action

* Actually use the latest

* fix new lint errors

* split linting into seperate action, go back to installing using curl rather than using the action

* fix version

* define new ctx key type for entry test

* use the key

* explicit linters in .golangci

Author: bmoffatt

.github/workflows/lint.yml

@@ -0,0 +1,25 @@
+name: tests
+on: 
+  push:
+  pull_request:
+
+jobs:
+
+  test:
+    name: lint 
+    runs-on: ubuntu-latest
+    steps:
+      - name: Set up Go 1.13
+        uses: actions/setup-go@v1
+        with:
+          go-version: 1.13
+        id: go
+
+      - name: Check out code into the Go module directory
+        uses: actions/checkout@v1
+
+      - name: golangci-golint
+        run: |
+          curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s v1.27.0
+          ./bin/golangci-lint run -v ./...
+

.github/workflows/tests.yml

@@ -6,7 +6,7 @@ on:
 jobs:
 
   test:
-    name: run tests and lint 
+    name: run tests with code coverage 
     runs-on: ubuntu-latest
     steps:
       - name: Set up Go 1.13
@@ -18,17 +18,6 @@ jobs:
       - name: Check out code into the Go module directory
         uses: actions/checkout@v1
 
-      - name: golangci-golint
-        run: |
-          curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s v1.22.2
-          ./bin/golangci-lint run -v ./...
-
-      - name: gofmt check
-        run: diff -u <(echo -n) <(gofmt -d ./)
-
-      - name: go vet
-        run: go vet -v ./...
-
       - name: go test
         run: go test -race -coverprofile=coverage.txt -covermode=atomic ./...
 

.golangci.yml

@@ -1,3 +1,18 @@
+linters:
+  disable-all: true
+  enable:
+    - gofmt
+    - errcheck
+    - deadcode
+    - gosimple 
+    - govet
+    - ineffassign
+    - staticcheck
+    - structcheck 
+    - typecheck
+    - unused
+    - varcheck
+
 run:
   skip-files:
     # These were code-generated, and cannot be changed without breaking RPC compatability.

lambda/entry_test.go

@@ -16,6 +16,8 @@ import (
 	"github.com/stretchr/testify/assert"
 )
 
+type ctxTestKey struct{}
+
 func TestStartRuntimeAPIWithContext(t *testing.T) {
 	server, _ := runtimeAPIServer("null", 1) // serve a single invoke, and then cause an internal error
 	expected := "expected"
@@ -26,8 +28,8 @@ func TestStartRuntimeAPIWithContext(t *testing.T) {
 	logFatalf = func(format string, v ...interface{}) {}
 	defer func() { logFatalf = log.Fatalf }()
 
-	StartWithContext(context.WithValue(context.Background(), "key", expected), func(ctx context.Context) error {
-		actual, _ = ctx.Value("key").(string)
+	StartWithContext(context.WithValue(context.Background(), ctxTestKey{}, expected), func(ctx context.Context) error {
+		actual, _ = ctx.Value(ctxTestKey{}).(string)
 		return nil
 	})
 
@@ -40,8 +42,8 @@ func TestStartRPCWithContext(t *testing.T) {
 	port := getFreeTCPPort()
 	os.Setenv("_LAMBDA_SERVER_PORT", fmt.Sprintf("%d", port))
 	defer os.Unsetenv("_LAMBDA_SERVER_PORT")
-	go StartWithContext(context.WithValue(context.Background(), "key", expected), func(ctx context.Context) error {
-		actual, _ = ctx.Value("key").(string)
+	go StartWithContext(context.WithValue(context.Background(), ctxTestKey{}, expected), func(ctx context.Context) error {
+		actual, _ = ctx.Value(ctxTestKey{}).(string)
 		return nil
 	})
 

lambda/function.go

@@ -57,6 +57,7 @@ func (fn *Function) Invoke(req *messages.InvokeRequest, response *messages.Invok
 	}
 	invokeContext = lambdacontext.NewContext(invokeContext, lc)
 
+	// nolint:staticcheck
 	invokeContext = context.WithValue(invokeContext, "x-amzn-trace-id", req.XAmznTraceId)
 	os.Setenv("_X_AMZN_TRACE_ID", req.XAmznTraceId)
 

lambda/function_test.go

@@ -6,7 +6,6 @@ import (
 	"context"
 	"encoding/json"
 	"errors"
-	"fmt"
 	"os"
 	"testing"
 	"time"
@@ -84,7 +83,7 @@ func TestInvokeWithContext(t *testing.T) {
 
 type CustomError struct{}
 
-func (e CustomError) Error() string { return fmt.Sprintf("Something bad happened!") }
+func (e CustomError) Error() string { return "Something bad happened!" }
 
 func TestCustomError(t *testing.T) {
 
@@ -103,7 +102,7 @@ func TestCustomError(t *testing.T) {
 
 type CustomError2 struct{}
 
-func (e *CustomError2) Error() string { return fmt.Sprintf("Something bad happened!") }
+func (e *CustomError2) Error() string { return "Something bad happened!" }
 
 func TestCustomErrorRef(t *testing.T) {