Remove in_place_update_on_fleet_enabled chef attribute

Author: hgreebe

cookbooks/aws-parallelcluster-platform/recipes/config/supervisord_config.rb

@@ -32,7 +32,6 @@
     dcv_port: node['cluster']['dcv_port'],
     dcv_auth_certificate: node['cluster']['dcv']['authenticator']['certificate'],
     dcv_auth_private_key: node['cluster']['dcv']['authenticator']['private_key'],
-    dcv_auth_user: node['cluster']['dcv']['authenticator']['user'],
-    cfnhup_enabled: cfnhup_enabled?
+    dcv_auth_user: node['cluster']['dcv']['authenticator']['user']
   )
 end

cookbooks/aws-parallelcluster-shared/attributes/cluster.rb

@@ -38,6 +38,3 @@
 
 # Default NFS mount options
 default['cluster']['nfs']['hard_mount_options'] = 'hard,_netdev,noatime'
-
-# Cluster Updates
-default['cluster']['in_place_update_on_fleet_enabled'] = 'true'

cookbooks/aws-parallelcluster-shared/libraries/helpers.rb

@@ -106,14 +106,3 @@ def wait_sync_file(path)
     timeout 5
   end
 end
-
-def cfnhup_enabled?
-  # cfn-hup is always enabled on the head node, as it is required to perform cluster updates.
-  # cfn-hup can be disabled on compute nodes and login nodes, limiting the cluster update in the sense that
-  # live updates on compute and login nodes are not possible.
-  node['cluster']['node_type'] == 'HeadNode' || node['cluster']['in_place_update_on_fleet_enabled'] == 'true'
-end
-
-def cluster_readiness_check_on_update_enabled?
-  node['cluster']['in_place_update_on_fleet_enabled'] == 'true'
-end

cookbooks/aws-parallelcluster-shared/spec/unit/libraries/helpers_spec.rb

@@ -280,7 +280,7 @@ def update_nodes_in_queue(strategy, queues)
 
 chef_sleep '15'
 
-wait_cluster_ready if cluster_readiness_check_on_update_enabled?
+wait_cluster_ready
 
 execute 'start clustermgtd' do
   command "#{cookbook_virtualenv_path}/bin/supervisorctl start clustermgtd"

cookbooks/aws-parallelcluster-slurm/recipes/update/update_head_node.rb

@@ -15,7 +15,6 @@
               allow_any_instance_of(Object).to receive(:are_mount_or_unmount_required?).and_return(are_mount_or_unmount_required)
               allow_any_instance_of(Object).to receive(:dig).and_return(true)
               allow_any_instance_of(Object).to receive(:cookbook_virtualenv_path).and_return(cookbook_venv_path)
-              allow_any_instance_of(Object).to receive(:cluster_readiness_check_on_update_enabled?).and_return(true)
               RSpec::Mocks.configuration.allow_message_expectations_on_nil = true
 
               node.override['cluster']['stack_name'] = cluster_name
@@ -81,7 +80,6 @@
             allow_any_instance_of(Object).to receive(:are_mount_or_unmount_required?).and_return(false)
             allow_any_instance_of(Object).to receive(:dig).and_return(true)
             allow_any_instance_of(Object).to receive(:cookbook_virtualenv_path).and_return(cookbook_venv_path)
-            allow_any_instance_of(Object).to receive(:cluster_readiness_check_on_update_enabled?).and_return(false)
             RSpec::Mocks.configuration.allow_message_expectations_on_nil = true
 
             node.override['cluster']['stack_name'] = cluster_name