updaing comments

Author: pulimsr

src/aws-cpp-sdk-transfer/source/transfer/TransferManager.cpp

@@ -1006,7 +1006,6 @@ namespace Aws
 
                 // Store full object checksum from HeadObject for validation
                 const auto& headResult = headObjectOutcome.GetResult();
-                // Capture any available checksum for validation (prioritize CRC32 as per SEP)
                 if (!headResult.GetChecksumCRC32().empty()) {
                     handle->SetChecksum(headResult.GetChecksumCRC32());
                 } else if (!headResult.GetChecksumCRC32C().empty()) {
@@ -1250,11 +1249,9 @@ namespace Aws
                 if (failedParts.size() == 0 && handle->GetBytesTransferred() == handle->GetBytesTotalSize())
                 {
                     outcome.GetResult().GetBody().flush();
-                    
-                    // Validate full object checksum if available
+
                     bool checksumValid = true;
                     if (!handle->GetChecksum().empty()) {
-                        // Combine part checksums to calculate full object checksum
                         Aws::String calculatedChecksum = CombinePartChecksums(handle);
 
                         if (!calculatedChecksum.empty() && calculatedChecksum != handle->GetChecksum()) {
@@ -1274,11 +1271,9 @@ namespace Aws
                             return;
                         }
                     }
-                    
-                    // Rename temp file to final file if using temporary file pattern
+
                     if (!handle->GetTargetFilePath().empty() && checksumValid) {
                         if (handle->GetTargetFilePath().find(".s3tmp.") != Aws::String::npos) {
-                            // This is a temp file, rename to final
                             Aws::String finalFile = handle->GetTargetFilePath();
                             size_t pos = finalFile.find(".s3tmp.");
                             if (pos != Aws::String::npos) {
@@ -1675,8 +1670,7 @@ namespace Aws
                 sortedParts.emplace_back(part.first, part.second->GetChecksum());
             }
             std::sort(sortedParts.begin(), sortedParts.end());
-            
-            // For CRC32, combine checksums using XOR (simplified approach)
+
             uint32_t combinedCrc = 0;
             for (const auto& part : sortedParts) {
                 char* endPtr = nullptr;
@@ -1688,34 +1682,29 @@ namespace Aws
                 }
                 combinedCrc ^= partCrc;
             }
-            
-            // Convert back to hex string
+
             std::stringstream ss;
             ss << std::hex << combinedCrc;
             return ss.str();
         }
 
         Aws::String TransferManager::GenerateTempFileName(const Aws::String& finalFileName) {
-            // Generate unique identifier (max 8 chars as per SEP)
             Aws::String uuid = Aws::Utils::UUID::RandomUUID();
             Aws::String uniqueId = uuid.length() > 8 ? uuid.substr(0, 8) : uuid;
             return finalFileName + ".s3tmp." + uniqueId;
         }
 
         bool TransferManager::RenameTempFileToFinal(const Aws::String& tempFile, const Aws::String& finalFile) {
-            // Use atomic rename if supported by platform
             if (std::rename(tempFile.c_str(), finalFile.c_str()) == 0) {
                 return true;
             }
-            
-            // Fallback strategy for platforms without atomic rename
+
             if (Aws::FileSystem::RemoveFileIfExists(finalFile.c_str())) {
                 if (std::rename(tempFile.c_str(), finalFile.c_str()) == 0) {
                     return true;
                 }
             }
-            
-            // Clean up temp file on failure
+
             Aws::FileSystem::RemoveFileIfExists(tempFile.c_str());
             return false;
         }

tests/aws-cpp-sdk-transfer-tests/TransferTests.cpp

@@ -2342,24 +2342,21 @@ TEST_P(TransferTests, TransferManager_DownloadWithChecksumValidationIntegrationT
 
     auto transferManager = TransferManager::Create(transferManagerConfig);
 
-    // Upload file with checksum enabled
     auto uploadPtr = transferManager->UploadFile(testFilePath, GetTestBucketName(), RandomFileName,
                                                 "text/plain", Aws::Map<Aws::String, Aws::String>());
 
     uploadPtr->WaitUntilFinished();
     ASSERT_EQ(TransferStatus::COMPLETED, uploadPtr->GetStatus());
     ASSERT_TRUE(WaitForObjectToPropagate(GetTestBucketName(), RandomFileName.c_str()));
 
-    // Download file - should validate checksum successfully
     Aws::String downloadFilePath = MakeFilePath((RandomFileName + "Download").c_str());
     auto downloadPtr = transferManager->DownloadFile(GetTestBucketName(), RandomFileName, downloadFilePath);
 
     downloadPtr->WaitUntilFinished();
-    
-    // Should complete successfully with valid checksum
+
     ASSERT_EQ(TransferStatus::COMPLETED, downloadPtr->GetStatus());
 
-    // Verify the downloaded file exists by trying to open it
+    // Verify the downloaded file exists
     std::ifstream file(downloadFilePath.c_str());
     ASSERT_TRUE(file.good());
     file.close();