Multi auth request level resolution #3632
Open
+534
−48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbiscigl
reviewed
Dec 1, 2025
| #include <aws/core/auth/signer/AWSAuthEventStreamV4Signer.h> | ||
| #include <aws/core/auth/signer/AWSNullSigner.h> | ||
|
|
||
| #include <smithy/identity/auth/built-in/NoAuthScheme.h> |
Contributor
There was a problem hiding this comment.
nit: why are we adding headers here if they arent used?
Contributor
Author
There was a problem hiding this comment.
Updated so these are only included during code gen if needed
|
|
||
| std::shared_ptr<AwsCredentialIdentityResolverT> identityResolver() override | ||
| { | ||
| return nullptr; |
Contributor
There was a problem hiding this comment.
not really a fan of using nullptr to denote NoAuthIdenitityResolver. could we just instead actually implement a NoAuthIdenitityResolver that just returns empty credentials. This would functionally work the same way as it does today in non-smithy clients.
|
|
||
| #if($serviceModel.useSmithyClient && $operation.auth) | ||
| Aws::Vector<smithy::AuthSchemeOption> ${typeInfo.className}::GetRequestSpecificSupportedAuth() const | ||
| { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Added support for request level auth resolution while maintaining backwards compatibility for non-smithy clients.
Check all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.