Skip to content

Conversation

@apache-hb
Copy link

Description of changes:

Since jdk23 lombok needs to be registered as an annotation processor explicitly otherwise it will not process java sources. This change applies the lombok recommended method of applying the annotation processor to fix builds on jdk23+

Check all that applies:

  • Did a review by yourself.
  • Added proper tests to cover this PR. (If tests are not applicable, explain.)
  • Checked if this PR is a breaking (APIs have been changed) change.
  • Checked if this PR will not introduce cross-platform inconsistent behavior.
  • Checked if this PR would require a ReadMe/Wiki update.

This doesnt effect generated sdk code, so I don't think any tests should be needed.

Check which platforms you have built SDK on to verify the correctness of this PR.

  • Linux
  • Windows
  • Android
  • MacOS
  • IOS
  • Other Platforms

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

…versions.

Since jdk23 lombok needs to be registered as an annotation processor explicitly otherwise it will not process java sources. This change applies the [lombok recommended method](https://projectlombok.org/setup/maven) of applying the annotation processor to fix builds on jdk23+
@sbiscigl
Copy link
Contributor

sbiscigl commented Dec 1, 2025

Why is this change needed? are you running the code generation standalone with a different JVM? the source in the SDK is the result of the running code gen on top of AWS models. curious how you are using the code gen where you would want this updated

@apache-hb
Copy link
Author

are you running the code generation standalone with a different JVM?

I was building the sdk locally and wanted to test a change I made to the code generator, but found I couldn't since I only have jdk25 installed locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants