Add debugger display for ValueStringBuilder.

teo-tsirpanis · teo-tsirpanis · commit 5daa0c1d5549 · 2025-07-19T22:15:36.000+03:00
diff --git a/sdk/src/Core/ThirdParty/RuntimeBackports/ValueStringBuilder.cs b/sdk/src/Core/ThirdParty/RuntimeBackports/ValueStringBuilder.cs
@@ -12,6 +12,7 @@
 
 namespace ThirdParty.RuntimeBackports
 {
+    [DebuggerDisplay("{DebuggerDisplay,nq}")]
 #pragma warning disable CA1815
     internal ref struct ValueStringBuilder
 #pragma warning restore CA1815
@@ -45,6 +46,9 @@ public int Length
             }
         }
 
+        // ToString() has side effects, so we don't want to call it from the debugger display.
+        private string DebuggerDisplay => AsSpan().ToString();
+
         public int Capacity => _chars.Length;
 
         public void EnsureCapacity(int capacity)

Original file line number	Diff line number	Diff line change
`@@ -12,6 +12,7 @@`
`12`	`12`
`13`	`13`	`namespace ThirdParty.RuntimeBackports`
`14`	`14`	`{`
	`15`	`+ [DebuggerDisplay("{DebuggerDisplay,nq}")]`
`15`	`16`	`#pragma warning disable CA1815`
`16`	`17`	`internal ref struct ValueStringBuilder`
`17`	`18`	`#pragma warning restore CA1815`
`@@ -45,6 +46,9 @@ public int Length`
`45`	`46`	`}`
`46`	`47`	`}`
`47`	`48`
	`49`	`+ // ToString() has side effects, so we don't want to call it from the debugger display.`
	`50`	`+ private string DebuggerDisplay => AsSpan().ToString();`
	`51`	`+`
`48`	`52`	`public int Capacity => _chars.Length;`
`49`	`53`
`50`	`54`	`public void EnsureCapacity(int capacity)`