Avoid setting config properties that don't exist in .NET Framework variant (#3935)

* For .NET Framework applications using AWSSDK.Extensions.NETCore.Setup avoid setting service client config properties that are not in the .NET Framework variant of the SDK.

* Add [MethodImpl(MethodImplOptions.NoInlining)] suggestion to avoid optimization triggering the runtime to check for HttpClientCacheSize too early

Author: normj

extensions/src/AWSSDK.Extensions.NETCore.Setup/AWSSDK.Extensions.NETCore.Setup.nuspec

@@ -3,7 +3,7 @@
   <metadata> 
     <id>AWSSDK.Extensions.NETCore.Setup</id>
     <title>AWSSDK - Extensions for NETCore Setup</title>
-    <version>4.0.2.0</version>
+    <version>4.0.2.1</version>
     <authors>Amazon Web Services</authors>
     <description>Extensions for the AWS SDK for .NET to integrate with .NET Core configuration and dependency injection frameworks.</description>
     <language>en-US</language>
@@ -14,19 +14,19 @@
 
     <dependencies>
       <group targetFramework="netstandard2.0">
-        <dependency id="AWSSDK.Core" version="4.0.0.12" />
+        <dependency id="AWSSDK.Core" version="4.0.0.18" />
         <dependency id="Microsoft.Extensions.Configuration.Abstractions" version="2.0.0" />
         <dependency id="Microsoft.Extensions.DependencyInjection.Abstractions" version="2.0.0" />
         <dependency id="Microsoft.Extensions.Logging.Abstractions" version="2.0.0" />
       </group>
       <group targetFramework="netcoreapp3.1">
-        <dependency id="AWSSDK.Core" version="4.0.0.12" />
+        <dependency id="AWSSDK.Core" version="4.0.0.18" />
         <dependency id="Microsoft.Extensions.Configuration.Abstractions" version="2.0.0" />
         <dependency id="Microsoft.Extensions.DependencyInjection.Abstractions" version="2.0.0" />
         <dependency id="Microsoft.Extensions.Logging.Abstractions" version="2.0.0" />
       </group>
       <group targetFramework="net8.0">
-        <dependency id="AWSSDK.Core" version="4.0.0.12" />
+        <dependency id="AWSSDK.Core" version="4.0.0.18" />
         <dependency id="Microsoft.Extensions.Configuration.Abstractions" version="2.0.0" />
         <dependency id="Microsoft.Extensions.DependencyInjection.Abstractions" version="8.0.0" />
         <dependency id="Microsoft.Extensions.Logging.Abstractions" version="2.0.0" />

extensions/src/AWSSDK.Extensions.NETCore.Setup/ClientFactory.cs

@@ -17,10 +17,12 @@
 using System.Diagnostics.CodeAnalysis;
 using System.Linq;
 using System.Reflection;
+using System.Runtime.CompilerServices;
 using System.Xml.Linq;
 using Amazon.Runtime;
 using Amazon.Runtime.CredentialManagement;
 using Amazon.Runtime.Credentials.Internal;
+using Amazon.Util;
 using Microsoft.Extensions.Configuration;
 using Microsoft.Extensions.DependencyInjection;
 using Microsoft.Extensions.Logging;
@@ -295,10 +297,6 @@ private ClientConfig CreateConfig(AWSOptions options)
             {
                 config.FastFailRequests = defaultConfig.FastFailRequests.Value;
             }
-            if (defaultConfig.HttpClientCacheSize.HasValue)
-            {
-                config.HttpClientCacheSize = defaultConfig.HttpClientCacheSize.Value;
-            }
             if (defaultConfig.IgnoreConfiguredEndpointUrls.HasValue)
             {
                 config.IgnoreConfiguredEndpointUrls = defaultConfig.IgnoreConfiguredEndpointUrls.Value;
@@ -367,9 +365,28 @@ private ClientConfig CreateConfig(AWSOptions options)
                 ProcessServiceSpecificSettings(config, defaultConfig.ServiceSpecificSettings);
             }
 
+            // It is possible that this library might be used in .NET Framework application. In that
+            // case the SDK used at runtime will be the .NET Framework variant. To avoid getting
+            // MissingMethodException exceptions for config properties that don't exist in 
+            // .NET Framework variant put the set calls in a separate method only called
+            // if the SDK is not the .NET Framework variant.
+            if (!AWSSDKUtils.IsNETFramework())
+            {
+                SetNETStandardAndAboveSettings(defaultConfig, config);
+            }
+
             return config;
         }
 
+        [MethodImpl(MethodImplOptions.NoInlining)]
+        private void SetNETStandardAndAboveSettings(DefaultClientConfig defaultConfig, ClientConfig config)
+        {
+            if (defaultConfig.HttpClientCacheSize.HasValue)
+            {
+                config.HttpClientCacheSize = defaultConfig.HttpClientCacheSize.Value;
+            }
+        }
+
 #if NET8_0_OR_GREATER
         [UnconditionalSuppressMessage("ReflectionAnalysis", "IL2075",
               Justification = "The parent calling method uses the DynamicDependencyAttribute on the service client to ensure the public properties are not trimmed.")]