eslint upgrade + fixing eslint issues

Author: Abdelhalim Dadouche

.eslintrc.js

@@ -1,13 +1,80 @@
+import typescriptEslintEslintPlugin from "@typescript-eslint/eslint-plugin";
+import tsdoc from "eslint-plugin-tsdoc";
 import globals from "globals";
-import pluginJs from "@eslint/js";
-import tseslint from "typescript-eslint";
+import tsParser from "@typescript-eslint/parser";
+import path from "node:path";
+import { fileURLToPath } from "node:url";
+import js from "@eslint/js";
+import { FlatCompat } from "@eslint/eslintrc";
 
+const __filename = fileURLToPath(import.meta.url);
+const __dirname = path.dirname(__filename);
 
-/** @type {import('eslint').Linter.Config[]} */
-export default [
-  {files: ["**/*.{js,mjs,cjs,ts}"]},
-  {files: ["**/*.js"], languageOptions: {sourceType: "commonjs"}},
-  {languageOptions: { globals: globals.browser }},
-  pluginJs.configs.recommended,
-  ...tseslint.configs.recommended,
+import { includeIgnoreFile } from "@eslint/compat";
+const gitignorePath = path.resolve(__dirname, ".gitignore");
+
+const compat = new FlatCompat({
+    baseDirectory: __dirname,
+    recommendedConfig: js.configs.recommended,
+    allConfig: js.configs.all
+});
+
+export default [...compat.extends(
+    "eslint:recommended",
+    "plugin:@typescript-eslint/recommended",
+    "plugin:prettier/recommended",
+), {
+    plugins: {
+        "@typescript-eslint": typescriptEslintEslintPlugin,
+        tsdoc,
+    },
+
+    languageOptions: {
+        globals: {
+            ...globals.browser,
+            ...globals.node,
+            ...globals.jest,
+            ...globals.commonjs,
+        },
+
+        parser: tsParser,
+        ecmaVersion: "latest",
+        sourceType: "module",
+
+        parserOptions: {
+            sourceType: 'module',
+            project: './tsconfig.json',
+        },
+    },
+
+    rules: {
+        "tsdoc/syntax": "warn",
+
+        "max-len": ["error", {
+            code: 150,
+            ignoreUrls: true,
+            ignoreStrings: true,
+            ignoreTemplateLiterals: true,
+            ignoreComments: true,
+            ignoreRegExpLiterals: true,
+        }],
+
+        "prettier/prettier": ["error", {
+            singleQuote: true,
+            trailingComma: "es5",
+        }],
+    },
+
+    ignores: [
+        "jest.config.js",
+        "package.json",
+        "package-lock.json",
+        "tsconfig.json",
+        "typedoc.json",
+    ],
+},
+includeIgnoreFile(gitignorePath),
+{
+    // your overrides
+},
 ];

eslint.config.mjs

@@ -1,8 +1,8 @@
-module.exports = {
-  testEnvironment: 'node',
-  roots: ['<rootDir>/test'],
-  testMatch: ['**/*.test.ts'],
+export default {
+  testEnvironment: "node",
+  roots: ["<rootDir>/test"],
+  testMatch: ["**/*.test.ts"],
   transform: {
-    '^.+\\.tsx?$': 'ts-jest',
+    "^.+\\.tsx?$": "ts-jest",
   },
 };

jest.config.js

@@ -35,7 +35,6 @@ export interface BuildImagePipelineProps extends cdk.StackProps {
   readonly serverAccessLogsPrefix?: string;
   /** Artifact bucket to use */
   readonly artifactBucket?: s3.Bucket;
-
 }
 
 /**
@@ -107,10 +106,10 @@ export class BuildImagePipelineStack extends cdk.Stack {
 
     let accessLoggingBucket: s3.IBucket;
 
-    if (props.accessLoggingBucket){
+    if (props.accessLoggingBucket) {
       accessLoggingBucket = props.accessLoggingBucket;
     } else {
-     accessLoggingBucket = new s3.Bucket(this, 'ArtifactAccessLogging', {
+      accessLoggingBucket = new s3.Bucket(this, 'ArtifactAccessLogging', {
         versioned: true,
         enforceSSL: true,
         autoDeleteObjects: true,
@@ -120,13 +119,13 @@ export class BuildImagePipelineStack extends cdk.Stack {
 
     let artifactBucket: s3.IBucket;
 
-    if (props.artifactBucket){
+    if (props.artifactBucket) {
       artifactBucket = props.artifactBucket;
     } else {
       const encryptionKey = new kms.Key(this, 'PipelineArtifactKey', {
-       removalPolicy: RemovalPolicy.DESTROY,
-       enableKeyRotation: true,
-     });
+        removalPolicy: RemovalPolicy.DESTROY,
+        enableKeyRotation: true,
+      });
       artifactBucket = new s3.Bucket(this, 'PipelineArtifacts', {
         versioned: true,
         enforceSSL: true,